Review Request: fix handling of return values of methods called by QtApplication.invokeDelegate

[BogDan Vatra]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103750/#review10024
-----------------------------------------------------------

Ship it!


Thank you for your patch! 
I had to rewrite your patch, to make it a little bit cleaner. 
http://commits.kde.org/android-qt/14464e63628de5570e295f3bf9a1337b81231acf

- BogDan Vatra


On Jan. 20, 2012, 8:59 p.m., Marijn Kruisselbrink wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103750/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2012, 8:59 p.m.)
> 
> 
> Review request for Necessitas.
> 
> 
> Description
> -------
> 
> QtApplication.invokeDelegate as it was written could never pass the return value of the invoked method back to its caller, as all it did was assign it to its local parameter (and since java always passes parameters by value this has zero effect). This fixes that by passing the return value parameter as an array, that way we can assign the value to a member of this array, and thus get around java's non-existing support for pass-by-reference parameters.
> 
> 
> Diffs
> -----
> 
>   src/android/java/src/org/kde/necessitas/origo/QtActivity.java 4ebf1f6 
>   src/android/java/src/org/kde/necessitas/origo/QtApplication.java a4d2601 
> 
> Diff: http://git.reviewboard.kde.org/r/103750/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marijn Kruisselbrink
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/necessitas-devel/attachments/20120123/6957c9ba/attachment.html>