<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103750/">http://git.reviewboard.kde.org/r/103750/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thank you for your patch!
I had to rewrite your patch, to make it a little bit cleaner.
http://commits.kde.org/android-qt/14464e63628de5570e295f3bf9a1337b81231acf</pre>
<br />
<p>- BogDan</p>
<br />
<p>On January 20th, 2012, 8:59 p.m., Marijn Kruisselbrink wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Necessitas.</div>
<div>By Marijn Kruisselbrink.</div>
<p style="color: grey;"><i>Updated Jan. 20, 2012, 8:59 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">QtApplication.invokeDelegate as it was written could never pass the return value of the invoked method back to its caller, as all it did was assign it to its local parameter (and since java always passes parameters by value this has zero effect). This fixes that by passing the return value parameter as an array, that way we can assign the value to a member of this array, and thus get around java's non-existing support for pass-by-reference parameters.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/android/java/src/org/kde/necessitas/origo/QtActivity.java <span style="color: grey">(4ebf1f6)</span></li>
<li>src/android/java/src/org/kde/necessitas/origo/QtApplication.java <span style="color: grey">(a4d2601)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103750/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>