Review Request: fix handling of return values of methods called by QtApplication.invokeDelegate

Marijn Kruisselbrink mkruisselbrink at kde.org
Fri Jan 20 20:59:40 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103750/
-----------------------------------------------------------

Review request for Necessitas.


Description
-------

QtApplication.invokeDelegate as it was written could never pass the return value of the invoked method back to its caller, as all it did was assign it to its local parameter (and since java always passes parameters by value this has zero effect). This fixes that by passing the return value parameter as an array, that way we can assign the value to a member of this array, and thus get around java's non-existing support for pass-by-reference parameters.


Diffs
-----

  src/android/java/src/org/kde/necessitas/origo/QtActivity.java 4ebf1f6 
  src/android/java/src/org/kde/necessitas/origo/QtApplication.java a4d2601 

Diff: http://git.reviewboard.kde.org/r/103750/diff/diff


Testing
-------


Thanks,

Marijn Kruisselbrink

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/necessitas-devel/attachments/20120120/0b4450a7/attachment.html>


More information about the Necessitas-devel mailing list