Review Request: fix QtApplication.onTerminate to do what I think it was supposed to do

BogDan Vatra bog_dan_ro at yahoo.com
Mon Jan 23 15:25:13 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103748/#review10023
-----------------------------------------------------------

Ship it!


Thank you !

http://commits.kde.org/android-qt/354b49e9ca277bbd7f391b2550a6f4dcba876094

- BogDan Vatra


On Jan. 20, 2012, 8:43 p.m., Marijn Kruisselbrink wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103748/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2012, 8:43 p.m.)
> 
> 
> Review request for Necessitas.
> 
> 
> Description
> -------
> 
> QtApplication.onTerminate called invokeDelegate, passing a list of Method's as first parameter, while it looks like it was intended to call invokeDelegateMethod, since after all it had just looked up a Method instance to call. This fixes that.
> 
> 
> Diffs
> -----
> 
>   src/android/java/src/org/kde/necessitas/origo/QtApplication.java a4d2601 
> 
> Diff: http://git.reviewboard.kde.org/r/103748/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marijn Kruisselbrink
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/necessitas-devel/attachments/20120123/b4c90de0/attachment.html>


More information about the Necessitas-devel mailing list