[MassifVisualizer] Review Request 113144: Fix more warnings when compiling massif-visualizer.

[Arnold Dumas]

On 08.10.2013 09:12, Milian Wolff wrote: 

> This is an
automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113144/ [1]
> 
> Sorry, but KDChart is
a copy of the upstream version and I want to keep the changes minimal.
I'll try to update KDChart to the latest release and see whether it
fixes the issues. If not, I'll forward your patches upstream - OK?
> 
>
The patch to tests/ is fine though, feel free to merge that part at
least.
> 
> - Milian Wolff 
> 
> On October 7th, 2013, 11:05 a.m. UTC,
Arnold Dumas wrote: 
> 
> Review request for Massif Visualizer. 
> By
Arnold Dumas. 
> 
> _Updated Oct. 7, 2013, 11:05 a.m._ 
> REPOSITORY:
massif-visualizer 
> 
> DESCRIPTION
> 
> This patch fix around thirty
warnings when compiling massif-visualizer. 
> 
> DIFFS
> 
> *
kdchart/src/KDChartBarDiagram_p.cpp (e1db2ab)
> *
kdchart/src/KDChartPercentLineDiagram_p.cpp (adb3e36)
> *
kdchart/src/KDChartPercentLyingBarDiagram_p.cpp (e624c28)
> *
kdchart/src/KDChartPieDiagram.cpp (be22459)
> *
kdchart/src/KDChartStackedLineDiagram_p.cpp (e80024a)
> *
kdchart/src/KDChartStackedPlotter_p.cpp (e724000)
> *
kdchart/src/Ternary/KDChartTernaryAxis.cpp (eb4500a)
> *
test/modeltest.cpp (b245202)
> 
> View Diff [2]

Ok, I totally
understand and it sounds like a good idea to not modify KDChart too
much. As a result I've discarded my review. 

Arnold 



Links:
------
[1] http://git.reviewboard.kde.org/r/113144/
[2]
http://git.reviewboard.kde.org/r/113144/diff/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/massif-visualizer/attachments/20131008/642a7203/attachment.html>