<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN">
<html><body>
<p>On 08.10.2013 09:12, Milian Wolff wrote:</p>
<blockquote type="cite" style="padding-left:5px; border-left:#1010ff 2px solid; margin-left:5px; width:100%"><!-- html ignored --><!-- head ignored --><!-- meta ignored -->
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table style="border: 1px solid #c9c399; width: 100%;" cellpadding="8" bgcolor="#f9f3c9">
<tbody>
<tr>
<td>This is an automatically generated e-mail. To reply, visit: <a href="http://git.reviewboard.kde.org/r/113144/">http://git.reviewboard.kde.org/r/113144/</a></td>
</tr>
</tbody>
</table>
<br />
<pre style="white-space: -o-pre-wrap; word-wrap: break-word;">Sorry, but KDChart is a copy of the upstream version and I want to keep the changes minimal. I'll try to update KDChart to the latest release and see whether it fixes the issues. If not, I'll forward your patches upstream - OK?
The patch to tests/ is fine though, feel free to merge that part at least.</pre>
<br />
<p>- Milian Wolff</p>
<br />
<p>On October 7th, 2013, 11:05 a.m. UTC, Arnold Dumas wrote:</p>
<table style="background-position: left top; background-repeat: repeat-x; border: 1px solid black; width: 100%;" cellspacing="0" cellpadding="8" bgcolor="#fefadf">
<tbody>
<tr>
<td>
<div>Review request for Massif Visualizer.</div>
<div>By Arnold Dumas.</div>
<p style="color: grey;"><em>Updated Oct. 7, 2013, 11:05 a.m.</em></p>
<div style="margin-top: 1.5em;"><strong style="color: #575012; font-size: 10pt;">Repository: </strong> massif-visualizer</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description</h1>
<table style="border: 1px solid #b8b5a0; width: 100%;" cellspacing="0" cellpadding="10" bgcolor="#ffffff">
<tbody>
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: -o-pre-wrap; word-wrap: break-word;">This patch fix around thirty warnings when compiling massif-visualizer. </pre>
</td>
</tr>
</tbody>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</h1>
<ul style="margin-left: 3em; padding-left: 0px;">
<li>kdchart/src/KDChartBarDiagram_p.cpp <span style="color: grey;">(e1db2ab)</span></li>
<li>kdchart/src/KDChartPercentLineDiagram_p.cpp <span style="color: grey;">(adb3e36)</span></li>
<li>kdchart/src/KDChartPercentLyingBarDiagram_p.cpp <span style="color: grey;">(e624c28)</span></li>
<li>kdchart/src/KDChartPieDiagram.cpp <span style="color: grey;">(be22459)</span></li>
<li>kdchart/src/KDChartStackedLineDiagram_p.cpp <span style="color: grey;">(e80024a)</span></li>
<li>kdchart/src/KDChartStackedPlotter_p.cpp <span style="color: grey;">(e724000)</span></li>
<li>kdchart/src/Ternary/KDChartTernaryAxis.cpp <span style="color: grey;">(eb4500a)</span></li>
<li>test/modeltest.cpp <span style="color: grey;">(b245202)</span></li>
</ul>
<p><a style="margin-left: 3em;" href="http://git.reviewboard.kde.org/r/113144/diff/">View Diff</a></p>
</td>
</tr>
</tbody>
</table>
</div>
</blockquote>
<p>Ok, I totally understand and it sounds like a good idea to not modify KDChart too much. As a result I've discarded my review.</p>
<p>Arnold</p>
<div> </div>
</body></html>