[MassifVisualizer] Review Request 113144: Fix more warnings when compiling massif-visualizer.

Milian Wolff mail at milianw.de
Tue Oct 8 08:12:24 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113144/#review41383
-----------------------------------------------------------


Sorry, but KDChart is a copy of the upstream version and I want to keep the changes minimal. I'll try to update KDChart to the latest release and see whether it fixes the issues. If not, I'll forward your patches upstream - OK?

The patch to tests/ is fine though, feel free to merge that part at least.

- Milian Wolff


On Oct. 7, 2013, 11:05 a.m., Arnold Dumas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113144/
> -----------------------------------------------------------
> 
> (Updated Oct. 7, 2013, 11:05 a.m.)
> 
> 
> Review request for Massif Visualizer.
> 
> 
> Repository: massif-visualizer
> 
> 
> Description
> -------
> 
> This patch fix around thirty warnings when compiling massif-visualizer. 
> 
> 
> Diffs
> -----
> 
>   kdchart/src/KDChartBarDiagram_p.cpp e1db2ab 
>   kdchart/src/KDChartPercentLineDiagram_p.cpp adb3e36 
>   kdchart/src/KDChartPercentLyingBarDiagram_p.cpp e624c28 
>   kdchart/src/KDChartPieDiagram.cpp be22459 
>   kdchart/src/KDChartStackedLineDiagram_p.cpp e80024a 
>   kdchart/src/KDChartStackedPlotter_p.cpp e724000 
>   kdchart/src/Ternary/KDChartTernaryAxis.cpp eb4500a 
>   test/modeltest.cpp b245202 
> 
> Diff: http://git.reviewboard.kde.org/r/113144/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arnold Dumas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/massif-visualizer/attachments/20131008/8e2e41e1/attachment.html>


More information about the Massif-visualizer mailing list