[Marble-devel] Review Request 123122: Formatted text widget.

Constantin Mihalache mihalache.c94 at gmail.com
Sat Mar 28 09:25:36 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123122/
-----------------------------------------------------------

(Updated March 28, 2015, 9:25 a.m.)


Review request for Marble, Calin Cruceru and Torsten Rahn.


Changes
-------

Fixed: passing QString as a const reference.


Repository: marble


Description
-------

#1 Widget implementation:
I've respected the structured given by EditPlacemarkDialog, which had formatted description.
I've first added this functionality to Polygon editing. (could continue adding it to GroundOverlay and Polyline if it's ok)
#2 Solved a visual bug in EditPolygonDialog:
The node table header didn't stretched with the window.


Diffs (updated)
-----

  src/lib/marble/CMakeLists.txt 6c65015 
  src/lib/marble/FormattedTextWidget.h PRE-CREATION 
  src/lib/marble/FormattedTextWidget.cpp PRE-CREATION 
  src/lib/marble/FormattedTextWidget.ui PRE-CREATION 
  src/plugins/render/annotate/EditPolygonDialog.cpp c647e6b 
  src/plugins/render/annotate/EditPolygonDialog.ui 563ca2d 

Diff: https://git.reviewboard.kde.org/r/123122/diff/


Testing
-------

It works.


Thanks,

Constantin Mihalache

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150328/3ad36fe6/attachment.html>


More information about the Marble-devel mailing list