[Marble-devel] Review Request 123122: Formatted text widget.

Constantin Mihalache mihalache.c94 at gmail.com
Sun Mar 29 09:36:25 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123122/
-----------------------------------------------------------

(Updated March 29, 2015, 9:36 a.m.)


Review request for Marble, Calin Cruceru and Torsten Rahn.


Changes
-------

Finished adding the widget to polylines and groundOverlays. Replaced the code in Placemark editing with the widget.


Repository: marble


Description (updated)
-------

#1 Widget implementation:
I've respected the structured given by EditPlacemarkDialog, which had formatted description.
I've first added this functionality to Polygon, Polyline and GroundOverlay editing.
I've also replaced the code in EditPlacemarkDialog with the widget.
#2 Solved a visual bug in EditPolygonDialog and EditPolylineDialog:
The node table header didn't stretch with the window.


Diffs
-----

  src/lib/marble/CMakeLists.txt 6c65015 
  src/lib/marble/FormattedTextWidget.h PRE-CREATION 
  src/lib/marble/FormattedTextWidget.cpp PRE-CREATION 
  src/lib/marble/FormattedTextWidget.ui PRE-CREATION 
  src/plugins/render/annotate/EditPolygonDialog.cpp c647e6b 
  src/plugins/render/annotate/EditPolygonDialog.ui 563ca2d 

Diff: https://git.reviewboard.kde.org/r/123122/diff/


Testing
-------

It works.


Thanks,

Constantin Mihalache

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150329/8fd8d94e/attachment.html>


More information about the Marble-devel mailing list