[Marble-devel] Review Request 123122: Formatted text widget.

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123122/#review78136
-----------------------------------------------------------



src/lib/marble/FormattedTextWidget.h (line 32)
<https://git.reviewboard.kde.org/r/123122/#comment53533>

    QString parameters should always be passed as a const reference :)


- Torsten Rahn


On März 27, 2015, 10:46 nachm., Constantin Mihalache wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123122/
> -----------------------------------------------------------
> 
> (Updated März 27, 2015, 10:46 nachm.)
> 
> 
> Review request for Marble, Calin Cruceru and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> #1 Widget implementation:
> I've respected the structured given by EditPlacemarkDialog, which had formatted description.
> I've first added this functionality to Polygon editing. (could continue adding it to GroundOverlay and Polyline if it's ok)
> #2 Solved a visual bug in EditPolygonDialog:
> The node table header didn't stretched with the window.
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/annotate/EditPolygonDialog.ui 563ca2d 
>   src/plugins/render/annotate/EditPolygonDialog.cpp c647e6b 
>   src/lib/marble/FormattedTextWidget.ui PRE-CREATION 
>   src/lib/marble/FormattedTextWidget.cpp PRE-CREATION 
>   src/lib/marble/FormattedTextWidget.h PRE-CREATION 
>   src/lib/marble/CMakeLists.txt 6c65015 
> 
> Diff: https://git.reviewboard.kde.org/r/123122/diff/
> 
> 
> Testing
> -------
> 
> It works.
> 
> 
> Thanks,
> 
> Constantin Mihalache
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150328/c37ce15b/attachment.html>