[Marble-devel] Review Request 124233: gsoc: Modifying the osm handlers to store OsmPlacemarkData

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124233/#review82611
-----------------------------------------------------------



src/plugins/runner/osm/handlers/OsmMemberTagHandler.cpp (line 67)
<https://git.reviewboard.kde.org/r/124233/#comment56962>

    %relid => %1, %wayid => %2



src/plugins/runner/osm/handlers/OsmNdTagHandler.cpp (line 14)
<https://git.reviewboard.kde.org/r/124233/#comment56963>

    please remove



src/plugins/runner/osm/handlers/OsmNdTagHandler.cpp (line 57)
<https://git.reviewboard.kde.org/r/124233/#comment56965>

    why not just call `const GeoDataCoordinates coordinates = p->coordinates();`? Shorter and would keep elevation also if that becomes relevant at some point. Using `p->coordinates()` directly should work as well.



src/plugins/runner/osm/handlers/OsmTagTagHandler.h (line 30)
<https://git.reviewboard.kde.org/r/124233/#comment56966>

    const GeoDataExtendedData &data


- Dennis Nienhüser


On July 17, 2015, 9:31 a.m., Marius Stanciu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124233/
> -----------------------------------------------------------
> 
> (Updated July 17, 2015, 9:31 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Sorry about this long patch, but i really could not separate it.
> Even though it looks long, it's mostly refactoring, not many important changes, apart from creating the OsmPlacemarkData objects.
> 
> 
> Diffs
> -----
> 
>   src/plugins/runner/osm/OsmParser.h 4436680 
>   src/plugins/runner/osm/OsmParser.cpp 7ad467b 
>   src/plugins/runner/osm/handlers/OsmElementDictionary.h 44a993c 
>   src/plugins/runner/osm/handlers/OsmElementDictionary.cpp f493e7b 
>   src/plugins/runner/osm/handlers/OsmMemberTagHandler.cpp 8fdfaae 
>   src/plugins/runner/osm/handlers/OsmNdTagHandler.cpp 3183560 
>   src/plugins/runner/osm/handlers/OsmNodeTagHandler.cpp e8dc85f 
>   src/plugins/runner/osm/handlers/OsmRelationTagHandler.cpp 5d900ba 
>   src/plugins/runner/osm/handlers/OsmTagTagHandler.h d4749da 
>   src/plugins/runner/osm/handlers/OsmTagTagHandler.cpp deaf32e 
>   src/plugins/runner/osm/handlers/OsmWayTagHandler.cpp df15102 
> 
> Diff: https://git.reviewboard.kde.org/r/124233/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marius Stanciu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150718/0417490e/attachment.html>