<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124233/">https://git.reviewboard.kde.org/r/124233/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/124233/diff/4/?file=385800#file385800line70" style="color: black; font-weight: bold; text-decoration: underline;">src/plugins/runner/osm/handlers/OsmMemberTagHandler.cpp</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">67</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">qWarning</span><span class="p">()</span><span class="o"><<</span> <span class="n">QString</span><span class="p">(</span> <span class="s">"Malformed relation %relid: No way with id %wayid exists"</span> <span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">%relid => %1, %wayid => %2</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/124233/diff/4/?file=385801#file385801line14" style="color: black; font-weight: bold; text-decoration: underline;">src/plugins/runner/osm/handlers/OsmNdTagHandler.cpp</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">14</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include <QDebug></span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">please remove</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/124233/diff/4/?file=385801#file385801line57" style="color: black; font-weight: bold; text-decoration: underline;">src/plugins/runner/osm/handlers/OsmNdTagHandler.cpp</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">GeoNode* OsmNdTagHandler::parse( GeoParser &geoParser ) const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">57</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">const</span> <span class="n">GeoDataCoordinates</span> <span class="n">coordinates</span><span class="p">(</span> <span class="n">p</span><span class="o">-></span><span class="n">coordinates</span><span class="p">().</span><span class="n">longitude</span><span class="p">(),</span> <span class="n">p</span><span class="o">-></span><span class="n">coordinates</span><span class="p">().</span><span class="n">latitude</span><span class="p">()</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">why not just call <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">const GeoDataCoordinates coordinates = p->coordinates();</code>? Shorter and would keep elevation also if that becomes relevant at some point. Using <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">p->coordinates()</code> directly should work as well.</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/124233/diff/4/?file=385804#file385804line31" style="color: black; font-weight: bold; text-decoration: underline;">src/plugins/runner/osm/handlers/OsmTagTagHandler.h</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">30</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">static</span> <span class="n">GeoDataPlacemark</span><span class="hl"> </span><span class="o"><span class="hl">*</span></span><span class="n">createPOI</span><span class="p">(</span> <span class="n">GeoDataDocument</span><span class="hl"> </span><span class="o"><span class="hl">*</span></span><span class="n">doc</span><span class="p">,</span> <span class="n">GeoDataGeometry</span><span class="hl"> </span><span class="o"><span class="hl">*</span></span><span class="n">geometry</span> <span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">30</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">static</span> <span class="n">GeoDataPlacemark</span><span class="o"><span class="hl">*</span></span><span class="hl"> </span><span class="n">createPOI</span><span class="p">(</span> <span class="n">GeoDataDocument</span><span class="o"><span class="hl">*</span></span><span class="hl"> </span><span class="n">doc</span><span class="p">,</span> <span class="n">GeoDataGeometry</span><span class="o"><span class="hl">*</span></span><span class="hl"> </span><span class="n">geometry</span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="n"><span class="hl">GeoDataExtendedData</span></span><span class="hl"> </span><span class="n"><span class="hl">data</span></span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">const GeoDataExtendedData &data</p></pre>
</div>
</div>
<br />
<p>- Dennis Nienhüser</p>
<br />
<p>On July 17th, 2015, 9:31 a.m. UTC, Marius Stanciu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Marius Stanciu.</div>
<p style="color: grey;"><i>Updated July 17, 2015, 9:31 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sorry about this long patch, but i really could not separate it.
Even though it looks long, it's mostly refactoring, not many important changes, apart from creating the OsmPlacemarkData objects.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plugins/runner/osm/OsmParser.h <span style="color: grey">(4436680)</span></li>
<li>src/plugins/runner/osm/OsmParser.cpp <span style="color: grey">(7ad467b)</span></li>
<li>src/plugins/runner/osm/handlers/OsmElementDictionary.h <span style="color: grey">(44a993c)</span></li>
<li>src/plugins/runner/osm/handlers/OsmElementDictionary.cpp <span style="color: grey">(f493e7b)</span></li>
<li>src/plugins/runner/osm/handlers/OsmMemberTagHandler.cpp <span style="color: grey">(8fdfaae)</span></li>
<li>src/plugins/runner/osm/handlers/OsmNdTagHandler.cpp <span style="color: grey">(3183560)</span></li>
<li>src/plugins/runner/osm/handlers/OsmNodeTagHandler.cpp <span style="color: grey">(e8dc85f)</span></li>
<li>src/plugins/runner/osm/handlers/OsmRelationTagHandler.cpp <span style="color: grey">(5d900ba)</span></li>
<li>src/plugins/runner/osm/handlers/OsmTagTagHandler.h <span style="color: grey">(d4749da)</span></li>
<li>src/plugins/runner/osm/handlers/OsmTagTagHandler.cpp <span style="color: grey">(deaf32e)</span></li>
<li>src/plugins/runner/osm/handlers/OsmWayTagHandler.cpp <span style="color: grey">(df15102)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124233/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>