[Marble-devel] Review Request 124233: gsoc: Modifying the osm handlers to store OsmPlacemarkData

Marius Stanciu stanciumarius94 at gmail.com
Fri Jul 17 09:31:23 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124233/
-----------------------------------------------------------

(Updated July 17, 2015, 9:31 a.m.)


Review request for Marble.


Changes
-------

reuploaded the patch, now reviewboard seems to take it


Repository: marble


Description
-------

Sorry about this long patch, but i really could not separate it.
Even though it looks long, it's mostly refactoring, not many important changes, apart from creating the OsmPlacemarkData objects.


Diffs (updated)
-----

  src/plugins/runner/osm/OsmParser.h 4436680 
  src/plugins/runner/osm/OsmParser.cpp 7ad467b 
  src/plugins/runner/osm/handlers/OsmElementDictionary.h 44a993c 
  src/plugins/runner/osm/handlers/OsmElementDictionary.cpp f493e7b 
  src/plugins/runner/osm/handlers/OsmMemberTagHandler.cpp 8fdfaae 
  src/plugins/runner/osm/handlers/OsmNdTagHandler.cpp 3183560 
  src/plugins/runner/osm/handlers/OsmNodeTagHandler.cpp e8dc85f 
  src/plugins/runner/osm/handlers/OsmRelationTagHandler.cpp 5d900ba 
  src/plugins/runner/osm/handlers/OsmTagTagHandler.h d4749da 
  src/plugins/runner/osm/handlers/OsmTagTagHandler.cpp deaf32e 
  src/plugins/runner/osm/handlers/OsmWayTagHandler.cpp df15102 

Diff: https://git.reviewboard.kde.org/r/124233/diff/


Testing
-------


Thanks,

Marius Stanciu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150717/d696869f/attachment-0001.html>


More information about the Marble-devel mailing list