[Marble-devel] Review Request 124834: Better zoom with the mouse wheel for the Openstreetmap map theme and added a new empty map theme for OSM file loading.

[Torsten Rahn]

> On Aug. 20, 2015, 6:03 nachm., Dennis Nienhüser wrote:
> > File Attachment: empty-preview.png - empty-preview.png
> > <https://git.reviewboard.kde.org/r/124834/#fcomment431>
> >
> >     we have a tool in tools/maptheme-previewimage/ to generate map theme preview images automatically. I uploaded its result to http://nienhueser.de/marble/empty-preview.png

This doesn't look consistent with the other icons: 

- the padding (space between circle and black square) should be bigger (about twice the current size)
- there needs to be a visible drop shadow


- Torsten


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124834/#review84098
-----------------------------------------------------------


On Aug. 20, 2015, 4:54 vorm., Dávid Kolozsvári wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124834/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2015, 4:54 vorm.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> * There is a `zoomAt()` and a `zoomBy()` method in `MarbleAbstractPresenter`, so I've created a new `void MarbleAbstractPresenter::zoomAtBy(const QPoint &pos, int zoomStep)` method to combine the functionality of both. This new method is used in `MarbleDefaultInputHandler::handleWheel()`, but only if the map theme is `Openstreetmap`.
> * The new `Empty` map theme is a simple 50 line .dgml file, with just a single empty geodata layer. Calling it `Empty` is a good idea or should we use another name for it?
> 
> 
> Diffs
> -----
> 
>   data/CMakeLists.txt 0a9c6e5 
>   src/lib/marble/MarbleAbstractPresenter.h 7fb203d 
>   src/lib/marble/MarbleAbstractPresenter.cpp acaab22 
>   src/lib/marble/MarbleInputHandler.cpp 393ce42 
> 
> Diff: https://git.reviewboard.kde.org/r/124834/diff/
> 
> 
> Testing
> -------
> 
> A small video demonstrating these two new features:
> https://www.youtube.com/watch?v=jMorQDwr2A8
> 
> 
> File Attachments
> ----------------
> 
> empty-preview.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/20/132190ff-11f7-45a2-b361-266f6aa752fc__empty-preview.png
> empty.dgml
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/20/39c98dcb-b35f-421a-bcf9-c3f95f15cfe3__empty.dgml
> 
> 
> Thanks,
> 
> Dávid Kolozsvári
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150820/919e686b/attachment-0001.html>