[Marble-devel] Review Request 124834: Better zoom with the mouse wheel for the Openstreetmap map theme and added a new empty map theme for OSM file loading.

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124834/#review84098
-----------------------------------------------------------



File Attachment: empty-preview.png - empty-preview.png
<https://git.reviewboard.kde.org//r/124834/#fcomment429>

    we have a tool in tools/maptheme-previewimage/ to generate map theme preview images automatically. I uploaded its result to http://nienhueser.de/marble/empty-preview.png



File Attachment: empty.dgml - empty.dgml
<https://git.reviewboard.kde.org//r/124834/#fcomment430>

    I'd go for a higher maximum zoom than `<maximum>3500</maximum>`



data/CMakeLists.txt (line 209)
<https://git.reviewboard.kde.org/r/124834/#comment58236>

    Since it is mostly useful only for developers I wouldn't want it to show up for users. The easiest way to accomplish that is to restrict its installment by a new cmake option called e.g. 'MARBLE_EMPTY_MAPTHEME' that defaults to OFF.



src/lib/marble/MarbleAbstractPresenter.cpp (line 261)
<https://git.reviewboard.kde.org/r/124834/#comment58237>

    `radiusVal = qBound( radius(minimumZoom(), radiusVal, radius(maximumZoom() );` is more readable



src/lib/marble/MarbleInputHandler.cpp (line 297)
<https://git.reviewboard.kde.org/r/124834/#comment58238>

    Wouldn't this be useful for any map theme that has no vector tiles? And what about not using it if the projection is different than the texture tile's projection (usually that's the case when the viewport's projection is not Mercator) since we won't reach a "sharp" display there?
    
    Torsten, any opinion on this?


- Dennis Nienhüser


On Aug. 20, 2015, 4:54 a.m., Dávid Kolozsvári wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124834/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2015, 4:54 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> * There is a `zoomAt()` and a `zoomBy()` method in `MarbleAbstractPresenter`, so I've created a new `void MarbleAbstractPresenter::zoomAtBy(const QPoint &pos, int zoomStep)` method to combine the functionality of both. This new method is used in `MarbleDefaultInputHandler::handleWheel()`, but only if the map theme is `Openstreetmap`.
> * The new `Empty` map theme is a simple 50 line .dgml file, with just a single empty geodata layer. Calling it `Empty` is a good idea or should we use another name for it?
> 
> 
> Diffs
> -----
> 
>   data/CMakeLists.txt 0a9c6e5 
>   src/lib/marble/MarbleAbstractPresenter.h 7fb203d 
>   src/lib/marble/MarbleAbstractPresenter.cpp acaab22 
>   src/lib/marble/MarbleInputHandler.cpp 393ce42 
> 
> Diff: https://git.reviewboard.kde.org/r/124834/diff/
> 
> 
> Testing
> -------
> 
> A small video demonstrating these two new features:
> https://www.youtube.com/watch?v=jMorQDwr2A8
> 
> 
> File Attachments
> ----------------
> 
> empty-preview.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/20/132190ff-11f7-45a2-b361-266f6aa752fc__empty-preview.png
> empty.dgml
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/20/39c98dcb-b35f-421a-bcf9-c3f95f15cfe3__empty.dgml
> 
> 
> Thanks,
> 
> Dávid Kolozsvári
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150820/7f5af451/attachment.html>