[Marble-devel] Review Request 124666: Added stacking to Marble Maps

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124666/#review83665
-----------------------------------------------------------


Yes, I like the idea of having interactive waypoint items. Design-wise I wonder if we get the message across by just using different colors for markers. Also the circular popup menu looks stylish, but might be annoying to extend/change (think of including the placemark's name, its distance or address in there). Code-wise it should be easier not to do the menu in C++, but in QML as a child item of the existing waypoint delegate (WaypointImage).


src/lib/marble/declarative/Routing.cpp (line 33)
<https://git.reviewboard.kde.org/r/124666/#comment57899>

    typo, missing a 't'


- Dennis Nienhüser


On Aug. 10, 2015, 11:37 a.m., Gábor Péterffy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124666/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2015, 11:37 a.m.)
> 
> 
> Review request for Marble, Mihail Ivchenko and Dennis Nienhüser.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> - Working back button
> - Reworked navigation setup
> 
> 
> Diffs
> -----
> 
>   data/android/drawable-xxxhdpi/circular_menu_backdrop.png PRE-CREATION 
>   data/android/drawable-xxxhdpi/delete_white.png PRE-CREATION 
>   data/android/drawable-xxxhdpi/place_blue.png PRE-CREATION 
>   src/apps/marble-maps/CircularMenu.qml PRE-CREATION 
>   src/apps/marble-maps/MainScreen.qml fafd183 
>   src/apps/marble-maps/MarbleMaps.qrc 713e414 
>   src/apps/marble-maps/NavigationSetup.qml eb7c1dd 
>   src/apps/marble-maps/RoutePlanViewer.qml 28b4c34 
>   src/apps/marble-maps/RoutingManager.qml PRE-CREATION 
>   src/apps/marble-maps/Search.qml 14088b8 
>   src/apps/marble-maps/WaypointImage.qml PRE-CREATION 
>   src/lib/marble/declarative/Routing.h 51a1be7 
>   src/lib/marble/declarative/Routing.cpp 7a0d8aa 
> 
> Diff: https://git.reviewboard.kde.org/r/124666/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> circular_menu_backdrop.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/090dd9dc-3208-4df3-95fd-9d3b59d3ecd0__circular_menu_backdrop.png
> place_blue.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/eb461d5e-79c7-410d-8fb6-c99ecc10180d__place_blue.png
> delete_white.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/adb4213f-398d-4c7d-b675-15e3b67ad4a1__delete_white.png
> Screenshot
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/68490e9b-18d6-465a-8f51-ce95ca571608__Screenshot_2015-08-10-13-20-49.png
> 
> 
> Thanks,
> 
> Gábor Péterffy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150810/eec03912/attachment.html>