[Marble-devel] Review Request 124666: Added stacking to Marble Maps

[Gábor Péterffy]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124666/
-----------------------------------------------------------

(Updated Aug. 10, 2015, 1:37 p.m.)


Review request for Marble, Mihail Ivchenko and Dennis Nienhüser.


Changes
-------

I have removed the NavigationMenu, and I have introduced a new way to set up a route. When you select a search result it will appear on the map. When you touch it, a menu will pop up where you can select how do you want to use it. With this, I not feel necessary to merge the profile selector into the WaypointOrderEditor. What do you think about it? Also do you like this approach instead the previous one?


Repository: marble


Description (updated)
-------

- Working back button
- Reworked navigation setup


Diffs (updated)
-----

  data/android/drawable-xxxhdpi/circular_menu_backdrop.png PRE-CREATION 
  data/android/drawable-xxxhdpi/delete_white.png PRE-CREATION 
  data/android/drawable-xxxhdpi/place_blue.png PRE-CREATION 
  src/apps/marble-maps/CircularMenu.qml PRE-CREATION 
  src/apps/marble-maps/MainScreen.qml fafd183 
  src/apps/marble-maps/MarbleMaps.qrc 713e414 
  src/apps/marble-maps/NavigationSetup.qml eb7c1dd 
  src/apps/marble-maps/RoutePlanViewer.qml 28b4c34 
  src/apps/marble-maps/RoutingManager.qml PRE-CREATION 
  src/apps/marble-maps/Search.qml 14088b8 
  src/apps/marble-maps/WaypointImage.qml PRE-CREATION 
  src/lib/marble/declarative/Routing.h 51a1be7 
  src/lib/marble/declarative/Routing.cpp 7a0d8aa 

Diff: https://git.reviewboard.kde.org/r/124666/diff/


Testing
-------


File Attachments (updated)
----------------

circular_menu_backdrop.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/090dd9dc-3208-4df3-95fd-9d3b59d3ecd0__circular_menu_backdrop.png
place_blue.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/eb461d5e-79c7-410d-8fb6-c99ecc10180d__place_blue.png
delete_white.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/adb4213f-398d-4c7d-b675-15e3b67ad4a1__delete_white.png
Screenshot
  https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/68490e9b-18d6-465a-8f51-ce95ca571608__Screenshot_2015-08-10-13-20-49.png


Thanks,

Gábor Péterffy

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150810/ba01f0fa/attachment.html>