<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124666/">https://git.reviewboard.kde.org/r/124666/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes, I like the idea of having interactive waypoint items. Design-wise I wonder if we get the message across by just using different colors for markers. Also the circular popup menu looks stylish, but might be annoying to extend/change (think of including the placemark's name, its distance or address in there). Code-wise it should be easier not to do the menu in C++, but in QML as a child item of the existing waypoint delegate (WaypointImage).</p></pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/124666/diff/2/?file=391981#file391981line33" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/marble/declarative/Routing.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">33</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="k">class</span> <span class="nc">SearchResulItem</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">typo, missing a 't'</p></pre>
</div>
</div>
<br />
<p>- Dennis Nienhüser</p>
<br />
<p>On August 10th, 2015, 11:37 a.m. UTC, Gábor Péterffy wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble, Mihail Ivchenko and Dennis Nienhüser.</div>
<div>By Gábor Péterffy.</div>
<p style="color: grey;"><i>Updated Aug. 10, 2015, 11:37 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Working back button</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Reworked navigation setup</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>data/android/drawable-xxxhdpi/circular_menu_backdrop.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/android/drawable-xxxhdpi/delete_white.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/android/drawable-xxxhdpi/place_blue.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble-maps/CircularMenu.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble-maps/MainScreen.qml <span style="color: grey">(fafd183)</span></li>
<li>src/apps/marble-maps/MarbleMaps.qrc <span style="color: grey">(713e414)</span></li>
<li>src/apps/marble-maps/NavigationSetup.qml <span style="color: grey">(eb7c1dd)</span></li>
<li>src/apps/marble-maps/RoutePlanViewer.qml <span style="color: grey">(28b4c34)</span></li>
<li>src/apps/marble-maps/RoutingManager.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble-maps/Search.qml <span style="color: grey">(14088b8)</span></li>
<li>src/apps/marble-maps/WaypointImage.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/declarative/Routing.h <span style="color: grey">(51a1be7)</span></li>
<li>src/lib/marble/declarative/Routing.cpp <span style="color: grey">(7a0d8aa)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124666/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/090dd9dc-3208-4df3-95fd-9d3b59d3ecd0__circular_menu_backdrop.png">circular_menu_backdrop.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/eb461d5e-79c7-410d-8fb6-c99ecc10180d__place_blue.png">place_blue.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/adb4213f-398d-4c7d-b675-15e3b67ad4a1__delete_white.png">delete_white.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/68490e9b-18d6-465a-8f51-ce95ca571608__Screenshot_2015-08-10-13-20-49.png">Screenshot</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>