[Marble-devel] Review Request 116797: Bug 331992 - Playlist item styling for KML Tours

[Cruceru Calin-Cristian]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116797/
-----------------------------------------------------------

(Updated March 16, 2014, 11:53 p.m.)


Review request for Marble.


Changes
-------

Made the following changes:
- replaced  #include <qabstracttextdocumentlayout.h> with #include <QAbstractTextDocumentLayout>;
- removed #include <QDebug>
- changed the TourItemDelegate::paint method so that it doesn't draw the explicit GeoData* classes names, but an icon associated to each of them;
- replaced settings-configure with document-edit from oxygen's actions for edit buttons;
- replaced manually-writing altitude/longitude/latitude with GeoDataCoordinates::toString();
- added an edit button for GeoDataSoundCue as well. Moved every Edit button on the same line with the icon representing the GeoData* elements and the Play button bellow it;
- the label of GeoDataSoundCue is now the exact path to the file being played;


Bugs: 331992
    http://bugs.kde.org/show_bug.cgi?id=331992


Repository: marble


Description
-------

I created a QStyledItemDelegate derived class in TourWidget.cpp which renders all playlist items. Also, I had to add some cases in GeoDataTreeModel.cpp in order to filter GeoDataWait/SoundCue/TourControl. If there is an easier method to do this and doesn't imply modifying GeoDataTreeModel.cpp, tell me and I'll adapt the code.
One more thing to mention is that I tried to add a suggestive icon to the edit and play buttons but I couldn't find the pictures' names.


Diffs (updated)
-----

  src/lib/marble/TourWidget.cpp da924f2 

Diff: https://git.reviewboard.kde.org/r/116797/diff/


Testing
-------


Thanks,

Cruceru Calin-Cristian

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140316/24db3396/attachment.html>