[Marble-devel] Review Request 116797: Bug 331992 - Playlist item styling for KML Tours

[Cruceru Calin-Cristian]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116797/
-----------------------------------------------------------

(Updated March 17, 2014, 11:29 p.m.)


Review request for Marble.


Changes
-------

Aligned everything in a single row. 
Solved the problem with the icons. 


Bugs: 331992
    http://bugs.kde.org/show_bug.cgi?id=331992


Repository: marble


Description
-------

I created a QStyledItemDelegate derived class in TourWidget.cpp which renders all playlist items. Also, I had to add some cases in GeoDataTreeModel.cpp in order to filter GeoDataWait/SoundCue/TourControl. If there is an easier method to do this and doesn't imply modifying GeoDataTreeModel.cpp, tell me and I'll adapt the code.
One more thing to mention is that I tried to add a suggestive icon to the edit and play buttons but I couldn't find the pictures' names.


Diffs (updated)
-----

  data/bitmaps/audio-x-generic.png PRE-CREATION 
  data/bitmaps/document-edit.png PRE-CREATION 
  data/bitmaps/media-playback-pause.png PRE-CREATION 
  data/bitmaps/player-time.png PRE-CREATION 
  src/lib/marble/TourWidget.cpp da924f2 
  src/lib/marble/libmarble.qrc d19c595 

Diff: https://git.reviewboard.kde.org/r/116797/diff/


Testing
-------


Thanks,

Cruceru Calin-Cristian

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140317/c19a921d/attachment.html>