[Marble-devel] Review Request 116797: Bug 331992 - Playlist item styling for KML Tours

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116797/#review53029
-----------------------------------------------------------


Nice one. Some polishing suggestions below.


src/lib/marble/TourWidget.cpp
<https://git.reviewboard.kde.org/r/116797/#comment37324>

    #include <QAbstractTextDocumentLayout>



src/lib/marble/TourWidget.cpp
<https://git.reviewboard.kde.org/r/116797/#comment37323>

    Please remove



src/lib/marble/TourWidget.cpp
<https://git.reviewboard.kde.org/r/116797/#comment37331>

    The class name is internal and shouldn't be shown to the user. I'd rather show an icon here, aligned horizontally to the other elements (like normal views do).
    GeoDataWait: player-time from Oxygen
    GeoDataFlyTo: default_location from Marble
    GeoDataSoundCue: audio-x-generic from Oxygen
    GeoDataTourControl: media-playback-pause from Oxygen
    



src/lib/marble/TourWidget.cpp
<https://git.reviewboard.kde.org/r/116797/#comment37328>

    document-edit from oxygen's actions fits better, same for the other occurences below



src/lib/marble/TourWidget.cpp
<https://git.reviewboard.kde.org/r/116797/#comment37332>

    Please use GeoDataCoordinates' toString() method here so that it gets formatted according to the user's preferences. It won't show the altitude then, but that's ok.



src/lib/marble/TourWidget.cpp
<https://git.reviewboard.kde.org/r/116797/#comment37333>

    How would the edit mode be triggered here?



src/lib/marble/TourWidget.cpp
<https://git.reviewboard.kde.org/r/116797/#comment37337>

    I think we can spare the Filename: prefix. Having the full path as a tooltip might be nice though



src/lib/marble/TourWidget.cpp
<https://git.reviewboard.kde.org/r/116797/#comment37322>

    Please add
    Q_UNUSED( option );
    Q_UNUSED( index );
    


- Dennis Nienhüser


On March 14, 2014, 10:34 p.m., Cruceru Calin-Cristian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116797/
> -----------------------------------------------------------
> 
> (Updated March 14, 2014, 10:34 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Bugs: 331992
>     http://bugs.kde.org/show_bug.cgi?id=331992
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> I created a QStyledItemDelegate derived class in TourWidget.cpp which renders all playlist items. Also, I had to add some cases in GeoDataTreeModel.cpp in order to filter GeoDataWait/SoundCue/TourControl. If there is an easier method to do this and doesn't imply modifying GeoDataTreeModel.cpp, tell me and I'll adapt the code.
> One more thing to mention is that I tried to add a suggestive icon to the edit and play buttons but I couldn't find the pictures' names.
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/TourWidget.cpp da924f2 
> 
> Diff: https://git.reviewboard.kde.org/r/116797/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Cruceru Calin-Cristian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140316/97b735b4/attachment-0001.html>