[Marble-devel] Review Request 116797: Bug 331992 - Playlist item styling for KML Tours

Cruceru Calin-Cristian crucerucalincristian at gmail.com
Fri Mar 14 22:34:52 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116797/
-----------------------------------------------------------

(Updated March 15, 2014, 12:34 a.m.)


Review request for Marble.


Changes
-------

Repaired buttons' icons.
Didn't make anymore any change in GeoDataTreeModel.cpp.
Used tr for shown text.


Bugs: 331992
    http://bugs.kde.org/show_bug.cgi?id=331992


Repository: marble


Description
-------

I created a QStyledItemDelegate derived class in TourWidget.cpp which renders all playlist items. Also, I had to add some cases in GeoDataTreeModel.cpp in order to filter GeoDataWait/SoundCue/TourControl. If there is an easier method to do this and doesn't imply modifying GeoDataTreeModel.cpp, tell me and I'll adapt the code.
One more thing to mention is that I tried to add a suggestive icon to the edit and play buttons but I couldn't find the pictures' names.


Diffs (updated)
-----

  src/lib/marble/TourWidget.cpp da924f2 

Diff: https://git.reviewboard.kde.org/r/116797/diff/


Testing
-------


Thanks,

Cruceru Calin-Cristian

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140314/a55bed59/attachment.html>


More information about the Marble-devel mailing list