[Marble-devel] Review Request 116797: Bug 331992 - Playlist item styling for KML Tours
Torsten Rahn
tackat at kde.org
Fri Mar 14 15:02:08 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116797/#review52939
-----------------------------------------------------------
For icons check e.g. the media-* files inside your local /usr/share/icons/default.kde4/16x16/actions/ folder.
- Torsten Rahn
On March 14, 2014, 1:45 p.m., Cruceru Calin-Cristian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116797/
> -----------------------------------------------------------
>
> (Updated March 14, 2014, 1:45 p.m.)
>
>
> Review request for Marble.
>
>
> Bugs: 331992
> http://bugs.kde.org/show_bug.cgi?id=331992
>
>
> Repository: marble
>
>
> Description
> -------
>
> I created a QStyledItemDelegate derived class in TourWidget.cpp which renders all playlist items. Also, I had to add some cases in GeoDataTreeModel.cpp in order to filter GeoDataWait/SoundCue/TourControl. If there is an easier method to do this and doesn't imply modifying GeoDataTreeModel.cpp, tell me and I'll adapt the code.
> One more thing to mention is that I tried to add a suggestive icon to the edit and play buttons but I couldn't find the pictures' names.
>
>
> Diffs
> -----
>
> src/lib/marble/GeoDataTreeModel.cpp 470f905
> src/lib/marble/TourWidget.cpp da924f2
> tests/data/Tour.kml beeb621
>
> Diff: https://git.reviewboard.kde.org/r/116797/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Cruceru Calin-Cristian
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140314/8878268a/attachment.html>
More information about the Marble-devel
mailing list