[Marble-devel] Review Request 118720: Resolve conflits in clipPainter class

[Gábor Péterffy]

> On June 13, 2014, 3:33 p.m., Dennis Nienhüser wrote:
> > Can you elaborate a bit where the problem occurs and which effects it has?
> > Renaming the methods like this implies that they're not used anywhere and can be removed altogether. I kind of doubt that, and instead would expect that some further changes would be needed which change setClipping() calls to setClipScreen() calls.

Currently nowhere in the code is used the setClipping() method, so it can be renamed without problem. But because the redeclaration, it can't be used to turn off clipping if you use one of the setClipRect() or setClipRegion() methods. I renamed the isClipping() method because it can be confused with the hasClipping() method of the base class.


- Gábor


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118720/#review59990
-----------------------------------------------------------


On June 13, 2014, 10:56 a.m., Gábor Péterffy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118720/
> -----------------------------------------------------------
> 
> (Updated June 13, 2014, 10:56 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> The current ClipPainter class overwrites some function of its base class QPainter and because of this some QPainter clipping functions is working and some not. With the renaming of some function, the original clipping method works again, and the ClipPainter class works as it should too.
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/ClipPainter.h 67715c5 
>   src/lib/marble/ClipPainter.cpp 74765a4 
> 
> Diff: https://git.reviewboard.kde.org/r/118720/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gábor Péterffy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140613/5bcab811/attachment-0001.html>