<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118720/">https://git.reviewboard.kde.org/r/118720/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 13th, 2014, 3:33 p.m. CEST, <b>Dennis Nienhüser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can you elaborate a bit where the problem occurs and which effects it has?
Renaming the methods like this implies that they're not used anywhere and can be removed altogether. I kind of doubt that, and instead would expect that some further changes would be needed which change setClipping() calls to setClipScreen() calls.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently nowhere in the code is used the setClipping() method, so it can be renamed without problem. But because the redeclaration, it can't be used to turn off clipping if you use one of the setClipRect() or setClipRegion() methods. I renamed the isClipping() method because it can be confused with the hasClipping() method of the base class.</pre>
<br />
<p>- Gábor</p>
<br />
<p>On June 13th, 2014, 10:56 a.m. CEST, Gábor Péterffy wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Gábor Péterffy.</div>
<p style="color: grey;"><i>Updated June 13, 2014, 10:56 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The current ClipPainter class overwrites some function of its base class QPainter and because of this some QPainter clipping functions is working and some not. With the renaming of some function, the original clipping method works again, and the ClipPainter class works as it should too.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/ClipPainter.h <span style="color: grey">(67715c5)</span></li>
<li>src/lib/marble/ClipPainter.cpp <span style="color: grey">(74765a4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118720/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>