[Marble-devel] Review Request 118720: Resolve conflits in clipPainter class

Dennis Nienhüser earthwings at gentoo.org
Tue Jun 17 21:11:34 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118720/#review60331
-----------------------------------------------------------

Ship it!


Ship It!

- Dennis Nienhüser


On June 13, 2014, 8:56 a.m., Gábor Péterffy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118720/
> -----------------------------------------------------------
> 
> (Updated June 13, 2014, 8:56 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> The current ClipPainter class overwrites some function of its base class QPainter and because of this some QPainter clipping functions is working and some not. With the renaming of some function, the original clipping method works again, and the ClipPainter class works as it should too.
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/ClipPainter.h 67715c5 
>   src/lib/marble/ClipPainter.cpp 74765a4 
> 
> Diff: https://git.reviewboard.kde.org/r/118720/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gábor Péterffy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140617/a1f8d475/attachment-0001.html>


More information about the Marble-devel mailing list