[Marble-devel] Review Request 116525: Added support to download remote images/icons

[Abhinav Gangwar]

> On June 28, 2014, 3:35 p.m., Thibaut Gridel wrote:
> > src/lib/marble/RemoteIconLoader.cpp, line 43
> > <https://git.reviewboard.kde.org/r/116525/diff/5/?file=255728#file255728line43>
> >
> >     The class is used through a static, and those attributes sound like they should be parameters passing in the methods. Otherwise the code would not be reentrant.
> >     
> >     Try adding parameters in eg searchLocalDir and initiateDownload and those attributes should become useless.

Thanks for mentioning it. Member m_url is useless if we pass the url in function parameters. :)


- Abhinav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116525/#review61123
-----------------------------------------------------------


On March 21, 2014, 9:02 a.m., Abhinav Gangwar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116525/
> -----------------------------------------------------------
> 
> (Updated March 21, 2014, 9:02 a.m.)
> 
> 
> Review request for Marble, Bernhard Beschow and Thibaut Gridel.
> 
> 
> Bugs: 310464
>     http://bugs.kde.org/show_bug.cgi?id=310464
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> The patch adds support to download remote images
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/CMakeLists.txt bb6f312 
>   src/lib/marble/PlacemarkLayout.cpp 408607b 
>   src/lib/marble/RemoteIconLoader.h PRE-CREATION 
>   src/lib/marble/RemoteIconLoader.cpp PRE-CREATION 
>   src/lib/marble/VisiblePlacemark.h 879e384 
>   src/lib/marble/VisiblePlacemark.cpp 8811598 
>   src/lib/marble/geodata/data/GeoDataIconStyle.h 9a4abbf 
>   src/lib/marble/geodata/data/GeoDataIconStyle.cpp b8310cf 
> 
> Diff: https://git.reviewboard.kde.org/r/116525/diff/
> 
> 
> Testing
> -------
> 
> Works fine on my system
> 
> 
> Thanks,
> 
> Abhinav Gangwar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140705/fe245a63/attachment.html>