[Marble-devel] Review Request 116525: Added support to download remote images/icons
Abhinav Gangwar
abhgang at gmail.com
Sat Jul 5 17:31:30 UTC 2014
> On June 28, 2014, 3:35 p.m., Thibaut Gridel wrote:
> > src/lib/marble/RemoteIconLoader.cpp, line 85
> > <https://git.reviewboard.kde.org/r/116525/diff/5/?file=255728#file255728line85>
> >
> > Is searchLocalDir different from what GeoDataIconStyle::icon() does using resolvePath ?
> >
> > Can you precise in comments maybe which one is used for which?
All the downloaded images are saved on disk at cache/icons/ ( relative address - for me it's "~/.local/share/marble/cache/icons/" ).
As I understood from GeoDataObject::resolvePath(..), using resolvePath() in GeoDataIconStyle::icon(), directory
'GeoDataDocument::baseUri() + iconPath' is searched.
- Abhinav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116525/#review61123
-----------------------------------------------------------
On March 21, 2014, 9:02 a.m., Abhinav Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116525/
> -----------------------------------------------------------
>
> (Updated March 21, 2014, 9:02 a.m.)
>
>
> Review request for Marble, Bernhard Beschow and Thibaut Gridel.
>
>
> Bugs: 310464
> http://bugs.kde.org/show_bug.cgi?id=310464
>
>
> Repository: marble
>
>
> Description
> -------
>
> The patch adds support to download remote images
>
>
> Diffs
> -----
>
> src/lib/marble/CMakeLists.txt bb6f312
> src/lib/marble/PlacemarkLayout.cpp 408607b
> src/lib/marble/RemoteIconLoader.h PRE-CREATION
> src/lib/marble/RemoteIconLoader.cpp PRE-CREATION
> src/lib/marble/VisiblePlacemark.h 879e384
> src/lib/marble/VisiblePlacemark.cpp 8811598
> src/lib/marble/geodata/data/GeoDataIconStyle.h 9a4abbf
> src/lib/marble/geodata/data/GeoDataIconStyle.cpp b8310cf
>
> Diff: https://git.reviewboard.kde.org/r/116525/diff/
>
>
> Testing
> -------
>
> Works fine on my system
>
>
> Thanks,
>
> Abhinav Gangwar
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140705/7cf1ea09/attachment.html>
More information about the Marble-devel
mailing list