[Marble-devel] Review Request 116525: Added support to download remote images/icons

[Abhinav Gangwar]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116525/
-----------------------------------------------------------

(Updated July 6, 2014, 12:39 a.m.)


Review request for Marble, Bernhard Beschow and Thibaut Gridel.


Changes
-------

Hi everyone :).
Sorry for taking long to respond to your reviews. I have fixed most of the issues.


Bugs: 310464
    http://bugs.kde.org/show_bug.cgi?id=310464


Repository: marble


Description
-------

The patch adds support to download remote images


Diffs (updated)
-----

  src/lib/marble/CMakeLists.txt a016307 
  src/lib/marble/PlacemarkLayout.cpp 408607b 
  src/lib/marble/RemoteIconLoader.h PRE-CREATION 
  src/lib/marble/RemoteIconLoader.cpp PRE-CREATION 
  src/lib/marble/VisiblePlacemark.cpp 8811598 
  src/lib/marble/geodata/data/GeoDataIconStyle.h 8838e49 
  src/lib/marble/geodata/data/GeoDataIconStyle.cpp 6902fcf 
  src/lib/marble/VisiblePlacemark.h 5356f4d 

Diff: https://git.reviewboard.kde.org/r/116525/diff/


Testing
-------

Works fine on my system


Thanks,

Abhinav Gangwar

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140705/dead1774/attachment-0001.html>