[Marble-devel] Review Request 116525: Added support to download remote images/icons

[Gábor Péterffy]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116525/#review61587
-----------------------------------------------------------


In the current state it can't handle if more style use the same icon url, because it creates a new HttpDownloadManager for every style so it can happen that a job will be multiple times started. This can be very bad if the icons are big files. The best would be, if the remote icon loaders will use the same HttpDownloadManager.

- Gábor Péterffy


On March 21, 2014, 3:32 a.m., Abhinav Gangwar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116525/
> -----------------------------------------------------------
> 
> (Updated March 21, 2014, 3:32 a.m.)
> 
> 
> Review request for Marble, Bernhard Beschow and Thibaut Gridel.
> 
> 
> Bugs: 310464
>     http://bugs.kde.org/show_bug.cgi?id=310464
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> The patch adds support to download remote images
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/CMakeLists.txt bb6f312 
>   src/lib/marble/PlacemarkLayout.cpp 408607b 
>   src/lib/marble/RemoteIconLoader.h PRE-CREATION 
>   src/lib/marble/RemoteIconLoader.cpp PRE-CREATION 
>   src/lib/marble/VisiblePlacemark.h 879e384 
>   src/lib/marble/VisiblePlacemark.cpp 8811598 
>   src/lib/marble/geodata/data/GeoDataIconStyle.h 9a4abbf 
>   src/lib/marble/geodata/data/GeoDataIconStyle.cpp b8310cf 
> 
> Diff: https://git.reviewboard.kde.org/r/116525/diff/
> 
> 
> Testing
> -------
> 
> Works fine on my system
> 
> 
> Thanks,
> 
> Abhinav Gangwar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140704/1c3e3cd7/attachment.html>