<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116525/">https://git.reviewboard.kde.org/r/116525/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In the current state it can't handle if more style use the same icon url, because it creates a new HttpDownloadManager for every style so it can happen that a job will be multiple times started. This can be very bad if the icons are big files. The best would be, if the remote icon loaders will use the same HttpDownloadManager.</pre>
<br />
<p>- Gábor Péterffy</p>
<br />
<p>On March 21st, 2014, 3:32 a.m. CET, Abhinav Gangwar wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble, Bernhard Beschow and Thibaut Gridel.</div>
<div>By Abhinav Gangwar.</div>
<p style="color: grey;"><i>Updated March 21, 2014, 3:32 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=310464">310464</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The patch adds support to download remote images</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works fine on my system</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/CMakeLists.txt <span style="color: grey">(bb6f312)</span></li>
<li>src/lib/marble/PlacemarkLayout.cpp <span style="color: grey">(408607b)</span></li>
<li>src/lib/marble/RemoteIconLoader.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/RemoteIconLoader.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/VisiblePlacemark.h <span style="color: grey">(879e384)</span></li>
<li>src/lib/marble/VisiblePlacemark.cpp <span style="color: grey">(8811598)</span></li>
<li>src/lib/marble/geodata/data/GeoDataIconStyle.h <span style="color: grey">(9a4abbf)</span></li>
<li>src/lib/marble/geodata/data/GeoDataIconStyle.cpp <span style="color: grey">(b8310cf)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116525/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>