[Marble-devel] Review Request 121363: TourWidget source separation (splitting into 10 files)

[Sanjiban Bairagya]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121363/#review71454
-----------------------------------------------------------


Please add a #include "FileName.moc" at the end of every NewFile.cpp that you added, otherwise it will give undefined reference errors while building

- Sanjiban Bairagya


On Dec. 6, 2014, 4:40 a.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121363/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2014, 4:40 a.m.)
> 
> 
> Review request for Marble, Dennis Nienhüser, Torsten Rahn, and Sanjiban Bairagya.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Related GCI-2014 task: http://www.google-melange.com/gci/task/view/google/gci2014/5859713304494080
> 
> TourWidget.{h|cpp} is overloaded with 6 different classes. I've separated 5 of these and put them into different files. Now it's more or less balanced.
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/CMakeLists.txt 439af82 
>   src/lib/marble/FlyToEditWidget.h PRE-CREATION 
>   src/lib/marble/FlyToEditWidget.cpp PRE-CREATION 
>   src/lib/marble/SoundCueEditWidget.h PRE-CREATION 
>   src/lib/marble/SoundCueEditWidget.cpp PRE-CREATION 
>   src/lib/marble/TourControlEditWidget.h PRE-CREATION 
>   src/lib/marble/TourControlEditWidget.cpp PRE-CREATION 
>   src/lib/marble/TourItemDelegate.h PRE-CREATION 
>   src/lib/marble/TourItemDelegate.cpp PRE-CREATION 
>   src/lib/marble/TourWidget.h af95b84 
>   src/lib/marble/TourWidget.cpp f301069 
>   src/lib/marble/WaitEditWidget.h PRE-CREATION 
>   src/lib/marble/WaitEditWidget.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121363/diff/
> 
> 
> Testing
> -------
> 
> Built & run
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20141206/746764b2/attachment.html>