[Marble-devel] Review Request 121363: TourWidget source separation (splitting into 10 files)

Illya Kovalevskyy illya.kovalevskyy at gmail.com
Sat Dec 6 08:02:30 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121363/
-----------------------------------------------------------

(Updated Dec. 6, 2014, 10:02 a.m.)


Review request for Marble, Dennis Nienhüser, Torsten Rahn, and Sanjiban Bairagya.


Changes
-------

Added .moc includes


Repository: marble


Description
-------

Related GCI-2014 task: http://www.google-melange.com/gci/task/view/google/gci2014/5859713304494080

TourWidget.{h|cpp} is overloaded with 6 different classes. I've separated 5 of these and put them into different files. Now it's more or less balanced.


Diffs (updated)
-----

  src/lib/marble/CMakeLists.txt 439af82 
  src/lib/marble/FlyToEditWidget.h PRE-CREATION 
  src/lib/marble/FlyToEditWidget.cpp PRE-CREATION 
  src/lib/marble/SoundCueEditWidget.h PRE-CREATION 
  src/lib/marble/SoundCueEditWidget.cpp PRE-CREATION 
  src/lib/marble/TourControlEditWidget.h PRE-CREATION 
  src/lib/marble/TourControlEditWidget.cpp PRE-CREATION 
  src/lib/marble/TourItemDelegate.h PRE-CREATION 
  src/lib/marble/TourItemDelegate.cpp PRE-CREATION 
  src/lib/marble/TourWidget.h af95b84 
  src/lib/marble/TourWidget.cpp f301069 
  src/lib/marble/WaitEditWidget.h PRE-CREATION 
  src/lib/marble/WaitEditWidget.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/121363/diff/


Testing
-------

Built & run


Thanks,

Illya Kovalevskyy

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20141206/aec80b95/attachment.html>


More information about the Marble-devel mailing list