<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121363/">https://git.reviewboard.kde.org/r/121363/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Please add a #include "FileName.moc" at the end of every NewFile.cpp that you added, otherwise it will give undefined reference errors while building</p></pre>
<br />
<p>- Sanjiban Bairagya</p>
<br />
<p>On December 6th, 2014, 4:40 a.m. IST, Illya Kovalevskyy wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble, Dennis Nienhüser, Torsten Rahn, and Sanjiban Bairagya.</div>
<div>By Illya Kovalevskyy.</div>
<p style="color: grey;"><i>Updated Dec. 6, 2014, 4:40 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Related GCI-2014 task: http://www.google-melange.com/gci/task/view/google/gci2014/5859713304494080</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">TourWidget.{h|cpp} is overloaded with 6 different classes. I've separated 5 of these and put them into different files. Now it's more or less balanced.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Built & run</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/CMakeLists.txt <span style="color: grey">(439af82)</span></li>
<li>src/lib/marble/FlyToEditWidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/FlyToEditWidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/SoundCueEditWidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/SoundCueEditWidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/TourControlEditWidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/TourControlEditWidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/TourItemDelegate.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/TourItemDelegate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/TourWidget.h <span style="color: grey">(af95b84)</span></li>
<li>src/lib/marble/TourWidget.cpp <span style="color: grey">(f301069)</span></li>
<li>src/lib/marble/WaitEditWidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/WaitEditWidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121363/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>