[Marble-devel] Review Request 120030: Multiple sessions

[Bernhard Beschow]

> On Sept. 9, 2014, 7:59 nachm., Bernhard Beschow wrote:
> > Can you please elaborate a bit on the "session" and why it is needed? This way we (as in I) have a chance to judge about the patch. Thx!
> > 
> > I'm looking forward for having panorama support in Marble.
> 
> Gábor Péterffy wrote:
>     A session basically  contains the following things:
>     - the model containing the data
>     - the map containig the layers, etc...
>     - the popup layer and the routing layer
>     
>     Important to store these because it would be very annoying when you open a panorama and after that everything would be just wiped out like when Marble is opened. So this is very important to improve the user experience. And of course as I wrote in the description this patch also opens a lot of possibilities.
> 
> Bernhard Beschow wrote:
>     Why not simply display another MarbleWidget on top? Why was 119538 discarded? What did I miss?
> 
> Gábor Péterffy wrote:
>     Maybe this conversation gives the answer for you: http://pastebin.com/8f56PcR7
>     So, we don't want to create a complete UI for a session, because we maybe want use it just in the background.

Copying the paste here for future reference:
<tackat> the problem with this patch is mostly
<tackat> that there isn't really a solution that will play nice with the rest of the code
<tackat> but we need the solution that is least invasive
<tackat> from what I get we have several options
<tackat> another option would be to reuse the same widget instead of stacking
<tackat> of course that would require to somehow restore the previous state when switching back - I don't know how feasible it is
<tackat> it might be the option though that is more elegant
<tackat> we have another problem: 
<tackat> if we want to print at high resolution
<tackat> ideally we'd like to turn on a higher geometry for the widget behind the user's back
<tackat> print that and get back to the previous "session" 
<tackat> could this code be reused for this use case?
<pgabor> In this code I store everything what is used in one session in a HistoryElement
<pgabor> and
<pgabor> this means you can do almost everything with it, it just not rendered for the user, and does not interact with the UI.
<pgabor> So you can create a copy of the current session
<pgabor> Do what you have to do
<pgabor> Then destroy it (or keep it, and when next needed just update it)
<pgabor> If I understood correctly what you want
<tackat> yep that's exactly what we need
<tackat> You know being able to reuse code for different use cases


- Bernhard


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120030/#review66151
-----------------------------------------------------------


On Sept. 4, 2014, 3 nachm., Gábor Péterffy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120030/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2014, 3 nachm.)
> 
> 
> Review request for Marble and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Adds the ability to save sessions at runtime and start a new one and later return to the previous one.
> 
> -This could be improved with adding the ability to change between sessions without closing any.
> -Also it could be improved/used up to create an undo ability (Maybe with QUndo?)
> -It could be used up to support high resolution printing with creating a session in the background
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/SessionManager.h PRE-CREATION 
>   src/lib/marble/SessionManager.cpp PRE-CREATION 
>   src/lib/marble/CMakeLists.txt 482a241a4e61fc26cede3b9140cbd320016d0ac2 
>   src/lib/marble/MarbleAbstractPresenter.h 9518e7e77797d026d78d4740a8c813c943868883 
>   src/lib/marble/MarbleAbstractPresenter.cpp ecb29cb90826c421ef90f423466f344bdbb498ac 
>   src/lib/marble/MarbleWidget.cpp 75d2d8f63021e5c278f5e57e30f03f093b068943 
> 
> Diff: https://git.reviewboard.kde.org/r/120030/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gábor Péterffy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20141203/8ae6e15c/attachment.html>