[Marble-devel] Review Request 120030: Multiple sessions

[Bernhard Beschow]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120030/#review71306
-----------------------------------------------------------



src/lib/marble/MarbleAbstractPresenter.cpp
<https://git.reviewboard.kde.org/r/120030/#comment49794>

    I think that there exists a "less invasive" solution than ripping out the guts of MarbleWidget and replace it with something completely new. I doubt that neither our internal code nor 3rd-party code (if that's a goal) is prepared for this.



src/lib/marble/MarbleAbstractPresenter.cpp
<https://git.reviewboard.kde.org/r/120030/#comment49795>

    What happens if model != m_map->model()?



src/lib/marble/SessionManager.cpp
<https://git.reviewboard.kde.org/r/120030/#comment49796>

    The routing layer is a value member (i.e. not a pointer) in MarbleWidget. So what's this attribute here supposed to do?



src/lib/marble/SessionManager.cpp
<https://git.reviewboard.kde.org/r/120030/#comment49797>

    Why not simply use a stack (or two, for going forward in history) here?


In essence, I am still looking for the reason why stacked widgets aren't considered simple enough.

- Bernhard Beschow


On Sept. 4, 2014, 3 nachm., Gábor Péterffy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120030/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2014, 3 nachm.)
> 
> 
> Review request for Marble and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Adds the ability to save sessions at runtime and start a new one and later return to the previous one.
> 
> -This could be improved with adding the ability to change between sessions without closing any.
> -Also it could be improved/used up to create an undo ability (Maybe with QUndo?)
> -It could be used up to support high resolution printing with creating a session in the background
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/SessionManager.h PRE-CREATION 
>   src/lib/marble/SessionManager.cpp PRE-CREATION 
>   src/lib/marble/CMakeLists.txt 482a241a4e61fc26cede3b9140cbd320016d0ac2 
>   src/lib/marble/MarbleAbstractPresenter.h 9518e7e77797d026d78d4740a8c813c943868883 
>   src/lib/marble/MarbleAbstractPresenter.cpp ecb29cb90826c421ef90f423466f344bdbb498ac 
>   src/lib/marble/MarbleWidget.cpp 75d2d8f63021e5c278f5e57e30f03f093b068943 
> 
> Diff: https://git.reviewboard.kde.org/r/120030/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gábor Péterffy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20141203/0211b3cd/attachment.html>