<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120030/">https://git.reviewboard.kde.org/r/120030/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 9th, 2014, 7:59 nachm. UTC, <b>Bernhard Beschow</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Can you please elaborate a bit on the "session" and why it is needed? This way we (as in I) have a chance to judge about the patch. Thx!</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm looking forward for having panorama support in Marble.</p></pre>
</blockquote>
<p>On September 15th, 2014, 8:55 nachm. UTC, <b>Gábor Péterffy</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">A session basically contains the following things:
- the model containing the data
- the map containig the layers, etc...
- the popup layer and the routing layer</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Important to store these because it would be very annoying when you open a panorama and after that everything would be just wiped out like when Marble is opened. So this is very important to improve the user experience. And of course as I wrote in the description this patch also opens a lot of possibilities.</p></pre>
</blockquote>
<p>On September 16th, 2014, 5:48 nachm. UTC, <b>Bernhard Beschow</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why not simply display another MarbleWidget on top? Why was 119538 discarded? What did I miss?</p></pre>
</blockquote>
<p>On September 18th, 2014, 8:33 vorm. UTC, <b>Gábor Péterffy</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Maybe this conversation gives the answer for you: http://pastebin.com/8f56PcR7
So, we don't want to create a complete UI for a session, because we maybe want use it just in the background.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Copying the paste here for future reference:
<tackat> the problem with this patch is mostly
<tackat> that there isn't really a solution that will play nice with the rest of the code
<tackat> but we need the solution that is least invasive
<tackat> from what I get we have several options
<tackat> another option would be to reuse the same widget instead of stacking
<tackat> of course that would require to somehow restore the previous state when switching back - I don't know how feasible it is
<tackat> it might be the option though that is more elegant
<tackat> we have another problem:
<tackat> if we want to print at high resolution
<tackat> ideally we'd like to turn on a higher geometry for the widget behind the user's back
<tackat> print that and get back to the previous "session"
<tackat> could this code be reused for this use case?
<pgabor> In this code I store everything what is used in one session in a HistoryElement
<pgabor> and
<pgabor> this means you can do almost everything with it, it just not rendered for the user, and does not interact with the UI.
<pgabor> So you can create a copy of the current session
<pgabor> Do what you have to do
<pgabor> Then destroy it (or keep it, and when next needed just update it)
<pgabor> If I understood correctly what you want
<tackat> yep that's exactly what we need
<tackat> You know being able to reuse code for different use cases</p></pre>
<br />
<p>- Bernhard</p>
<br />
<p>On September 4th, 2014, 3 nachm. UTC, Gábor Péterffy wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble and Torsten Rahn.</div>
<div>By Gábor Péterffy.</div>
<p style="color: grey;"><i>Updated Sept. 4, 2014, 3 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Adds the ability to save sessions at runtime and start a new one and later return to the previous one.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">-This could be improved with adding the ability to change between sessions without closing any.
-Also it could be improved/used up to create an undo ability (Maybe with QUndo?)
-It could be used up to support high resolution printing with creating a session in the background</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/SessionManager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/SessionManager.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/CMakeLists.txt <span style="color: grey">(482a241a4e61fc26cede3b9140cbd320016d0ac2)</span></li>
<li>src/lib/marble/MarbleAbstractPresenter.h <span style="color: grey">(9518e7e77797d026d78d4740a8c813c943868883)</span></li>
<li>src/lib/marble/MarbleAbstractPresenter.cpp <span style="color: grey">(ecb29cb90826c421ef90f423466f344bdbb498ac)</span></li>
<li>src/lib/marble/MarbleWidget.cpp <span style="color: grey">(75d2d8f63021e5c278f5e57e30f03f093b068943)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120030/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>