[Marble-devel] Junior job "Get rid of compile warnings" : patch proposal

Dennis Nienhüser earthwings at gentoo.org
Thu Sep 26 06:09:11 UTC 2013


Hi Arnold,

thanks for the patch. The variables there are leftovers from changes in
the translation related parts. Since they're not needed anymore, it
would be better to remove them entirely instead of marking them unused.
Can you change the patch to do that?

Thanks,
Dennis

On 24.09.2013 17:36, contact at arnolddumas.com wrote:
> Hello there,
>
> I'm using KDE for a while now and since I'm a student and got plenty
> of time to kill, I'd like to contribute to it.
> I saw the "Junior jobs" and the job named : "Get rid of compile
> warnings". Therefore I've wrote a ridiculously simple patch to fix
> three warnings.
> This patch is intentionally simple, so I can get used to the KDE
> infrastructure.
> I'm highly motivated to work on all the other warnings to fix, notably
> those present when -DPEDANTIC=ON is set.
>
> Hope my patch will help,
>
> Arnold
>
>
> _______________________________________________
> Marble-devel mailing list
> Marble-devel at kde.org
> https://mail.kde.org/mailman/listinfo/marble-devel



More information about the Marble-devel mailing list