[Marble-devel] Junior job "Get rid of compile warnings" : patch proposal

contact at arnolddumas.com contact at arnolddumas.com
Tue Sep 24 15:36:43 UTC 2013


Hello there,

I'm using KDE for a while now and since I'm a student and got plenty 
of time to kill, I'd like to contribute to it.
I saw the "Junior jobs" and the job named : "Get rid of compile 
warnings". Therefore I've wrote a ridiculously simple patch to fix 
three warnings.
This patch is intentionally simple, so I can get used to the KDE 
infrastructure.
I'm highly motivated to work on all the other warnings to fix, notably 
those present when -DPEDANTIC=ON is set.

Hope my patch will help,

Arnold
-------------- next part --------------
diff --git a/src/plugins/render/satellites/SatellitesConfigDialog.cpp b/src/plugins/render/satellites/SatellitesConfigDialog.cpp
index 6939759..5115929 100644
--- a/src/plugins/render/satellites/SatellitesConfigDialog.cpp
+++ b/src/plugins/render/satellites/SatellitesConfigDialog.cpp
@@ -35,6 +35,7 @@ SatellitesConfigDialog::SatellitesConfigDialog( QWidget *parent )
     // allow translation for catalog items
     // + categories
     const char *descCat = "An object category";
+    Q_UNUSED(descCat)
     m_translations["Comets"]        = tr( "Comets" );
     m_translations["Moons"]         = tr( "Moons" );
     m_translations["Other"]         = tr( "Other" );
@@ -42,6 +43,7 @@ SatellitesConfigDialog::SatellitesConfigDialog( QWidget *parent )
     m_translations["Spaceprobes"]  = tr( "Spaceprobes" );
     // + bodies
     const char *descBodies = "A planet or space body";
+    Q_UNUSED(descBodies)
     m_translations["Moon"]          = tr( "Moon" );
     m_translations["Sun"]           = tr( "Sun" );
     m_translations["Mercury"]       = tr( "Mercury" );
diff --git a/src/plugins/render/satellites/SatellitesPlugin.cpp b/src/plugins/render/satellites/SatellitesPlugin.cpp
index 7a36bda..833081c 100644
--- a/src/plugins/render/satellites/SatellitesPlugin.cpp
+++ b/src/plugins/render/satellites/SatellitesPlugin.cpp
@@ -366,6 +366,7 @@ void SatellitesPlugin::activateDataSource( const QString &source )
 void SatellitesPlugin::addBuiltInDataSources()
 {
     const char *desc = "A category of satellites to be displayed";
+    Q_UNUSED(desc)
     QString currentCategory;
 
     currentCategory = tr("Special-Interest Satellites" );


More information about the Marble-devel mailing list