[Marble-devel] Junior job "Get rid of compile warnings" : patch proposal

[Arnold Dumas]

Le 26/09/2013 07:09, Dennis Nienhüser a écrit :
> Hi Arnold,
>
> thanks for the patch. The variables there are leftovers from changes in
> the translation related parts. Since they're not needed anymore, it
> would be better to remove them entirely instead of marking them unused.
> Can you change the patch to do that?
>
> Thanks,
> Dennis
>
> On 24.09.2013 17:36, contact at arnolddumas.com wrote:
>> Hello there,
>>
>> I'm using KDE for a while now and since I'm a student and got plenty
>> of time to kill, I'd like to contribute to it.
>> I saw the "Junior jobs" and the job named : "Get rid of compile
>> warnings". Therefore I've wrote a ridiculously simple patch to fix
>> three warnings.
>> This patch is intentionally simple, so I can get used to the KDE
>> infrastructure.
>> I'm highly motivated to work on all the other warnings to fix, notably
>> those present when -DPEDANTIC=ON is set.
>>
>> Hope my patch will help,
>>
>> Arnold
>>
>>
>> _______________________________________________
>> Marble-devel mailing list
>> Marble-devel at kde.org
>> https://mail.kde.org/mailman/listinfo/marble-devel
> _______________________________________________
> Marble-devel mailing list
> Marble-devel at kde.org
> https://mail.kde.org/mailman/listinfo/marble-devel
Ok, I've just created a new patch.
Should I consider posting it directly to git.reviewboard.kde.org in the 
marb-devel group ?

Cheers,

Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.diff
Type: text/x-patch
Size: 1563 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130926/880f5d0f/attachment.diff>