[Marble-devel] Review Request 113904: ESA SoCIS 2013 - Move SolarSystem 2013 libs into marble central place

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113904/#review43841
-----------------------------------------------------------


Thinking of a future split of Marble into more than one library (currently everything goes into one library, libmarblewidget) I'd like to share some thoughts on how to separate things cleanly. I see two approaches for a possible modularization here:

1) astro is a separate library bundled with Marble. That would mean
  - files in src/lib/astro
  - headers go to include/astro
  - no use of Marble namespace
  - no use of any other Marble resources, e.g. the export headers
  - created as a shared library on its own linked to libmarblewidget (for the time being we could do a static library similar to src/apps/marble-ui)

2) astro is a module of Marble (like later on libmarblecore, libmarblewidget)
  - files in src/lib/marble/astro
  - headers go to include/marble/astro
  - use of Marble namespace
  - use of other Marble resources as needed (respecting dependencies, e.g. not using GUI resources later on)
  - built as part of libmarblewidget, later on to be changed to become a shared library on its own when creating other libraries like libmarblecore

The current patch mixes both things:
  (1) files in src/lib/astro
  (2) headers installed to include/marble
  (2) use of Marble namespace
  (2) use of Marble resources (export macro)
  (2) build as part of libmarblewidget


- Dennis Nienhüser


On Nov. 16, 2013, 5:39 p.m., Marek Hakala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113904/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2013, 5:39 p.m.)
> 
> 
> Review request for Marble, Torsten Rahn and René Küttner.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> ESA SoCIS 2013 - Move SolarSystem 2013 libs into marble central place
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/eclipses/res/solar_total.png PRE-CREATION 
>   src/plugins/render/satellites/CMakeLists.txt 03650a4 
>   src/plugins/render/satellites/SatellitesMSCItem.h f1fff67 
>   src/plugins/render/satellites/SatellitesModel.cpp 5d73653 
>   src/plugins/render/satellites/mex/README 2903c53 
>   src/plugins/render/satellites/mex/astrolib.h 8a878e8 
>   src/plugins/render/satellites/mex/astrolib.cpp a1d5cbf 
>   src/plugins/render/satellites/mex/attlib.h 7e209cf 
>   src/plugins/render/satellites/mex/attlib.cpp 0264bd7 
>   src/plugins/render/satellites/mex/planetarySats.h 0ed34c7 
>   src/plugins/render/satellites/mex/planetarySats.cpp ec31a20 
>   src/plugins/render/eclipses/EclipsesBrowserDialog.ui PRE-CREATION 
>   src/plugins/render/eclipses/EclipsesConfigDialog.ui PRE-CREATION 
>   src/plugins/render/eclipses/EclipsesItem.h PRE-CREATION 
>   src/plugins/render/eclipses/EclipsesItem.cpp PRE-CREATION 
>   src/plugins/render/eclipses/EclipsesModel.h PRE-CREATION 
>   src/plugins/render/eclipses/EclipsesModel.cpp PRE-CREATION 
>   src/plugins/render/eclipses/EclipsesPlugin.h PRE-CREATION 
>   src/plugins/render/eclipses/EclipsesPlugin.cpp PRE-CREATION 
>   src/plugins/render/eclipses/EclipsesReminderDialog.ui PRE-CREATION 
>   src/plugins/render/eclipses/eclipses.qrc PRE-CREATION 
>   src/plugins/render/eclipses/res/eclipses.png PRE-CREATION 
>   src/plugins/render/eclipses/res/lunar_partial.png PRE-CREATION 
>   src/plugins/render/eclipses/res/lunar_penumbra.png PRE-CREATION 
>   src/plugins/render/eclipses/res/lunar_total.png PRE-CREATION 
>   src/plugins/render/eclipses/res/solar_annular.png PRE-CREATION 
>   src/plugins/render/eclipses/res/solar_partial.png PRE-CREATION 
>   src/lib/marble/astro/eclsolar.cpp PRE-CREATION 
>   src/lib/marble/astro/planetarySats.h PRE-CREATION 
>   src/lib/marble/astro/planetarySats.cpp PRE-CREATION 
>   src/lib/marble/astro/solarsystem.h PRE-CREATION 
>   src/lib/marble/astro/solarsystem.cpp PRE-CREATION 
>   src/plugins/render/CMakeLists.txt c62070f 
>   src/plugins/render/eclipses/CMakeLists.txt PRE-CREATION 
>   src/plugins/render/eclipses/EclipsesBrowserDialog.h PRE-CREATION 
>   src/plugins/render/eclipses/EclipsesBrowserDialog.cpp PRE-CREATION 
>   src/lib/marble/astro/astrolib.cpp PRE-CREATION 
>   src/lib/marble/astro/attlib.h PRE-CREATION 
>   src/lib/marble/astro/attlib.cpp PRE-CREATION 
>   src/lib/marble/astro/eclsolar.h PRE-CREATION 
>   src/apps/marble-kde/marble_part.cpp 98092a8 
>   src/apps/marble-kde/marble_part.rc baa3618 
>   src/apps/marble-qt/QtMainWindow.h 80ae250 
>   src/apps/marble-qt/QtMainWindow.cpp 5615f65 
>   src/lib/marble/CMakeLists.txt 8f2c6eb 
>   src/lib/marble/RenderPlugin.cpp a51b27f 
>   src/lib/marble/astro/CMakeLists.txt PRE-CREATION 
>   src/lib/marble/astro/README PRE-CREATION 
>   src/lib/marble/astro/astr2lib.h PRE-CREATION 
>   src/lib/marble/astro/astr2lib.cpp PRE-CREATION 
>   src/lib/marble/astro/astrolib.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/113904/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marek Hakala
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131117/84c11717/attachment.html>