[Marble-devel] Review Request 113904: ESA SoCIS 2013 - Move SolarSystem 2013 libs into marble central place

[René Küttner]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113904/#review44036
-----------------------------------------------------------


Marek: It seems like you mixed up moving the astro libs and adding plugin controlled menu entries in this diff. Could you remove the changes not related astro lis from this diff? You may add them as a separate review request?

- René Küttner


On Nov. 16, 2013, 5:39 p.m., Marek Hakala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113904/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2013, 5:39 p.m.)
> 
> 
> Review request for Marble, Torsten Rahn and René Küttner.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> ESA SoCIS 2013 - Move SolarSystem 2013 libs into marble central place
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/eclipses/res/solar_total.png PRE-CREATION 
>   src/plugins/render/satellites/CMakeLists.txt 03650a4 
>   src/plugins/render/satellites/SatellitesMSCItem.h f1fff67 
>   src/plugins/render/satellites/SatellitesModel.cpp 5d73653 
>   src/plugins/render/satellites/mex/README 2903c53 
>   src/plugins/render/satellites/mex/astrolib.h 8a878e8 
>   src/plugins/render/satellites/mex/astrolib.cpp a1d5cbf 
>   src/plugins/render/satellites/mex/attlib.h 7e209cf 
>   src/plugins/render/satellites/mex/attlib.cpp 0264bd7 
>   src/plugins/render/satellites/mex/planetarySats.h 0ed34c7 
>   src/plugins/render/satellites/mex/planetarySats.cpp ec31a20 
>   src/plugins/render/eclipses/EclipsesBrowserDialog.ui PRE-CREATION 
>   src/plugins/render/eclipses/EclipsesConfigDialog.ui PRE-CREATION 
>   src/plugins/render/eclipses/EclipsesItem.h PRE-CREATION 
>   src/plugins/render/eclipses/EclipsesItem.cpp PRE-CREATION 
>   src/plugins/render/eclipses/EclipsesModel.h PRE-CREATION 
>   src/plugins/render/eclipses/EclipsesModel.cpp PRE-CREATION 
>   src/plugins/render/eclipses/EclipsesPlugin.h PRE-CREATION 
>   src/plugins/render/eclipses/EclipsesPlugin.cpp PRE-CREATION 
>   src/plugins/render/eclipses/EclipsesReminderDialog.ui PRE-CREATION 
>   src/plugins/render/eclipses/eclipses.qrc PRE-CREATION 
>   src/plugins/render/eclipses/res/eclipses.png PRE-CREATION 
>   src/plugins/render/eclipses/res/lunar_partial.png PRE-CREATION 
>   src/plugins/render/eclipses/res/lunar_penumbra.png PRE-CREATION 
>   src/plugins/render/eclipses/res/lunar_total.png PRE-CREATION 
>   src/plugins/render/eclipses/res/solar_annular.png PRE-CREATION 
>   src/plugins/render/eclipses/res/solar_partial.png PRE-CREATION 
>   src/lib/marble/astro/eclsolar.cpp PRE-CREATION 
>   src/lib/marble/astro/planetarySats.h PRE-CREATION 
>   src/lib/marble/astro/planetarySats.cpp PRE-CREATION 
>   src/lib/marble/astro/solarsystem.h PRE-CREATION 
>   src/lib/marble/astro/solarsystem.cpp PRE-CREATION 
>   src/plugins/render/CMakeLists.txt c62070f 
>   src/plugins/render/eclipses/CMakeLists.txt PRE-CREATION 
>   src/plugins/render/eclipses/EclipsesBrowserDialog.h PRE-CREATION 
>   src/plugins/render/eclipses/EclipsesBrowserDialog.cpp PRE-CREATION 
>   src/lib/marble/astro/astrolib.cpp PRE-CREATION 
>   src/lib/marble/astro/attlib.h PRE-CREATION 
>   src/lib/marble/astro/attlib.cpp PRE-CREATION 
>   src/lib/marble/astro/eclsolar.h PRE-CREATION 
>   src/apps/marble-kde/marble_part.cpp 98092a8 
>   src/apps/marble-kde/marble_part.rc baa3618 
>   src/apps/marble-qt/QtMainWindow.h 80ae250 
>   src/apps/marble-qt/QtMainWindow.cpp 5615f65 
>   src/lib/marble/CMakeLists.txt 8f2c6eb 
>   src/lib/marble/RenderPlugin.cpp a51b27f 
>   src/lib/marble/astro/CMakeLists.txt PRE-CREATION 
>   src/lib/marble/astro/README PRE-CREATION 
>   src/lib/marble/astro/astr2lib.h PRE-CREATION 
>   src/lib/marble/astro/astr2lib.cpp PRE-CREATION 
>   src/lib/marble/astro/astrolib.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/113904/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marek Hakala
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131120/4317c1ee/attachment-0001.html>