<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113904/">http://git.reviewboard.kde.org/r/113904/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thinking of a future split of Marble into more than one library (currently everything goes into one library, libmarblewidget) I'd like to share some thoughts on how to separate things cleanly. I see two approaches for a possible modularization here:
1) astro is a separate library bundled with Marble. That would mean
- files in src/lib/astro
- headers go to include/astro
- no use of Marble namespace
- no use of any other Marble resources, e.g. the export headers
- created as a shared library on its own linked to libmarblewidget (for the time being we could do a static library similar to src/apps/marble-ui)
2) astro is a module of Marble (like later on libmarblecore, libmarblewidget)
- files in src/lib/marble/astro
- headers go to include/marble/astro
- use of Marble namespace
- use of other Marble resources as needed (respecting dependencies, e.g. not using GUI resources later on)
- built as part of libmarblewidget, later on to be changed to become a shared library on its own when creating other libraries like libmarblecore
The current patch mixes both things:
(1) files in src/lib/astro
(2) headers installed to include/marble
(2) use of Marble namespace
(2) use of Marble resources (export macro)
(2) build as part of libmarblewidget
</pre>
<br />
<p>- Dennis Nienhüser</p>
<br />
<p>On November 16th, 2013, 5:39 p.m. UTC, Marek Hakala wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble, Torsten Rahn and René Küttner.</div>
<div>By Marek Hakala.</div>
<p style="color: grey;"><i>Updated Nov. 16, 2013, 5:39 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ESA SoCIS 2013 - Move SolarSystem 2013 libs into marble central place</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plugins/render/eclipses/res/solar_total.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/satellites/CMakeLists.txt <span style="color: grey">(03650a4)</span></li>
<li>src/plugins/render/satellites/SatellitesMSCItem.h <span style="color: grey">(f1fff67)</span></li>
<li>src/plugins/render/satellites/SatellitesModel.cpp <span style="color: grey">(5d73653)</span></li>
<li>src/plugins/render/satellites/mex/README <span style="color: grey">(2903c53)</span></li>
<li>src/plugins/render/satellites/mex/astrolib.h <span style="color: grey">(8a878e8)</span></li>
<li>src/plugins/render/satellites/mex/astrolib.cpp <span style="color: grey">(a1d5cbf)</span></li>
<li>src/plugins/render/satellites/mex/attlib.h <span style="color: grey">(7e209cf)</span></li>
<li>src/plugins/render/satellites/mex/attlib.cpp <span style="color: grey">(0264bd7)</span></li>
<li>src/plugins/render/satellites/mex/planetarySats.h <span style="color: grey">(0ed34c7)</span></li>
<li>src/plugins/render/satellites/mex/planetarySats.cpp <span style="color: grey">(ec31a20)</span></li>
<li>src/plugins/render/eclipses/EclipsesBrowserDialog.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/eclipses/EclipsesConfigDialog.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/eclipses/EclipsesItem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/eclipses/EclipsesItem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/eclipses/EclipsesModel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/eclipses/EclipsesModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/eclipses/EclipsesPlugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/eclipses/EclipsesPlugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/eclipses/EclipsesReminderDialog.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/eclipses/eclipses.qrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/eclipses/res/eclipses.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/eclipses/res/lunar_partial.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/eclipses/res/lunar_penumbra.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/eclipses/res/lunar_total.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/eclipses/res/solar_annular.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/eclipses/res/solar_partial.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/astro/eclsolar.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/astro/planetarySats.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/astro/planetarySats.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/astro/solarsystem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/astro/solarsystem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/CMakeLists.txt <span style="color: grey">(c62070f)</span></li>
<li>src/plugins/render/eclipses/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/eclipses/EclipsesBrowserDialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/eclipses/EclipsesBrowserDialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/astro/astrolib.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/astro/attlib.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/astro/attlib.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/astro/eclsolar.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble-kde/marble_part.cpp <span style="color: grey">(98092a8)</span></li>
<li>src/apps/marble-kde/marble_part.rc <span style="color: grey">(baa3618)</span></li>
<li>src/apps/marble-qt/QtMainWindow.h <span style="color: grey">(80ae250)</span></li>
<li>src/apps/marble-qt/QtMainWindow.cpp <span style="color: grey">(5615f65)</span></li>
<li>src/lib/marble/CMakeLists.txt <span style="color: grey">(8f2c6eb)</span></li>
<li>src/lib/marble/RenderPlugin.cpp <span style="color: grey">(a51b27f)</span></li>
<li>src/lib/marble/astro/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/astro/README <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/astro/astr2lib.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/astro/astr2lib.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/astro/astrolib.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113904/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>