[Marble-devel] Review Request 112454: Ground Overlay Editing

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112454/#review42882
-----------------------------------------------------------


Thanks, the patch looks pretty nice on quick view. Some changes in the general classes could go into master independently as they fix general issues.

Parts of the patch do not show up (see reviewboard error in between). It would be great if you could look into that.



src/lib/FileViewWidget.cpp
<http://git.reviewboard.kde.org/r/112454/#comment30991>

    When the user cancels the dialog, an empty string is returned. In this case saveFile() should not be called. Please split up the line.
    
    Please use something more descriptive than "Save To", e.g. "Select filename for KML document"
    



src/lib/FileViewWidget.cpp
<http://git.reviewboard.kde.org/r/112454/#comment30992>

    See above


- Dennis Nienhüser


On Sept. 23, 2013, 7:11 p.m., Adrian Draghici wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112454/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2013, 7:11 p.m.)
> 
> 
> Review request for Marble, Bernhard Beschow, Dennis Nienhüser, Torsten Rahn, and Thibaut Gridel.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Adds support for editing ground overlays.
> 
> 
> Diffs
> -----
> 
>   src/lib/FileManager.h ae648f7 
>   src/lib/FileManager.cpp e5551a6 
>   src/lib/FileViewWidget.cpp 2412aec 
>   src/lib/MarbleMap.h 7019bfa 
>   src/lib/MarbleMap.cpp caf92d9 
>   src/lib/MarbleWidget.h 6493a6c 
>   src/lib/MarbleWidget.cpp 026d996 
>   src/lib/geodata/writers/kml/KmlLatLonBoxWriter.cpp f920b51 
>   src/lib/geodata/writers/kml/KmlOverlayTagWriter.cpp 16c8a14 
>   src/lib/layers/TextureLayer.h cabcd99 
>   src/marble.qrc 753bf24 
>   src/plugins/render/annotate/AnnotatePlugin.h 41ad2cb 
>   src/plugins/render/annotate/AnnotatePlugin.cpp c6ff1bb 
>   src/plugins/render/annotate/CMakeLists.txt d6097e2 
>   src/plugins/render/annotate/EditGroundOverlayDialog.h e69de29 
>   src/plugins/render/annotate/EditGroundOverlayDialog.cpp e69de29 
>   src/plugins/render/annotate/EditGroundOverlayDialog.ui e69de29 
>   src/plugins/render/annotate/GroundOverlayFrame.h e69de29 
>   src/plugins/render/annotate/GroundOverlayFrame.cpp e69de29 
> 
> Diff: http://git.reviewboard.kde.org/r/112454/diff/
> 
> 
> Testing
> -------
> 
> Manually tested with various overlays.
> 
> 
> File Attachments
> ----------------
> 
> Icon used for adding overlays
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/02/draw-overlay.png
> 
> 
> Thanks,
> 
> Adrian Draghici
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131103/7eb920d6/attachment.html>