<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112454/">http://git.reviewboard.kde.org/r/112454/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks, the patch looks pretty nice on quick view. Some changes in the general classes could go into master independently as they fix general issues.
Parts of the patch do not show up (see reviewboard error in between). It would be great if you could look into that.
</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112454/diff/3/?file=191777#file191777line118" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/FileViewWidget.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void FileViewWidgetPrivate::saveFile()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">117</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_fileManager</span><span class="o">-></span><span class="n">saveFile</span><span class="p">(</span> <span class="n">document</span> <span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">118</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_fileManager</span><span class="o">-></span><span class="n">saveFile</span><span class="p">(</span> <span class="n"><span class="hl">QFileDialog</span></span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">getSaveFileName</span></span><span class="p"><span class="hl">(</span></span><span class="hl"> </span><span class="n"><span class="hl">q</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="s"><span class="hl">"Save To"</span></span><span class="hl"> </span><span class="p"><span class="hl">),</span></span><span class="hl"> </span><span class="n">document</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When the user cancels the dialog, an empty string is returned. In this case saveFile() should not be called. Please split up the line.
Please use something more descriptive than "Save To", e.g. "Select filename for KML document"
</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112454/diff/3/?file=191777#file191777line129" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/FileViewWidget.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void FileViewWidgetPrivate::saveFile()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">128</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_fileManager</span><span class="o">-></span><span class="n"><span class="hl">clos</span>eFile</span><span class="p">(</span> <span class="n">document</span> <span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">129</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_fileManager</span><span class="o">-></span><span class="n"><span class="hl">sav</span>eFile</span><span class="p">(</span><span class="hl"> </span><span class="n"><span class="hl">QFileDialog</span></span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">getSaveFileName</span></span><span class="p"><span class="hl">(</span></span><span class="hl"> </span><span class="n"><span class="hl">q</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="s"><span class="hl">"Save To"</span></span><span class="hl"> </span><span class="p"><span class="hl">),</span></span> <span class="n">document</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">See above</pre>
</div>
<br />
<p>- Dennis Nienhüser</p>
<br />
<p>On September 23rd, 2013, 7:11 p.m. UTC, Adrian Draghici wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble, Bernhard Beschow, Dennis Nienhüser, Torsten Rahn, and Thibaut Gridel.</div>
<div>By Adrian Draghici.</div>
<p style="color: grey;"><i>Updated Sept. 23, 2013, 7:11 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adds support for editing ground overlays.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Manually tested with various overlays.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/FileManager.h <span style="color: grey">(ae648f7)</span></li>
<li>src/lib/FileManager.cpp <span style="color: grey">(e5551a6)</span></li>
<li>src/lib/FileViewWidget.cpp <span style="color: grey">(2412aec)</span></li>
<li>src/lib/MarbleMap.h <span style="color: grey">(7019bfa)</span></li>
<li>src/lib/MarbleMap.cpp <span style="color: grey">(caf92d9)</span></li>
<li>src/lib/MarbleWidget.h <span style="color: grey">(6493a6c)</span></li>
<li>src/lib/MarbleWidget.cpp <span style="color: grey">(026d996)</span></li>
<li>src/lib/geodata/writers/kml/KmlLatLonBoxWriter.cpp <span style="color: grey">(f920b51)</span></li>
<li>src/lib/geodata/writers/kml/KmlOverlayTagWriter.cpp <span style="color: grey">(16c8a14)</span></li>
<li>src/lib/layers/TextureLayer.h <span style="color: grey">(cabcd99)</span></li>
<li>src/marble.qrc <span style="color: grey">(753bf24)</span></li>
<li>src/plugins/render/annotate/AnnotatePlugin.h <span style="color: grey">(41ad2cb)</span></li>
<li>src/plugins/render/annotate/AnnotatePlugin.cpp <span style="color: grey">(c6ff1bb)</span></li>
<li>src/plugins/render/annotate/CMakeLists.txt <span style="color: grey">(d6097e2)</span></li>
<li>src/plugins/render/annotate/EditGroundOverlayDialog.h <span style="color: grey">(e69de29)</span></li>
<li>src/plugins/render/annotate/EditGroundOverlayDialog.cpp <span style="color: grey">(e69de29)</span></li>
<li>src/plugins/render/annotate/EditGroundOverlayDialog.ui <span style="color: grey">(e69de29)</span></li>
<li>src/plugins/render/annotate/GroundOverlayFrame.h <span style="color: grey">(e69de29)</span></li>
<li>src/plugins/render/annotate/GroundOverlayFrame.cpp <span style="color: grey">(e69de29)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112454/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/02/draw-overlay.png">Icon used for adding overlays</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>