[Marble-devel] Review Request 111499: GroundOverlay Rendering

[Dennis Nienhüser]

> On July 14, 2013, 10:31 a.m., Dennis Nienhüser wrote:
> > src/lib/layers/TextureLayer.cpp, line 172
> > <http://git.reviewboard.kde.org/r/111499/diff/1/?file=170557#file170557line172>
> >
> >     Is it possible to use just one cast?
> 
> Adrian Draghici wrote:
>     Not in this case, it doesn't work without it...

Adding Q_DECLARE_METATYPE( Marble::GeoDataGroundOverlay* ) towards the end of GeoDataGroundOverlay.h should fix that (cf. GeoDataObject.h)


- Dennis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111499/#review35925
-----------------------------------------------------------


On July 15, 2013, 11:30 a.m., Adrian Draghici wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111499/
> -----------------------------------------------------------
> 
> (Updated July 15, 2013, 11:30 a.m.)
> 
> 
> Review request for Marble, Bernhard Beschow, Dennis Nienhüser, Torsten Rahn, and Thibaut Gridel.
> 
> 
> Description
> -------
> 
> This patch adds support for rendering GroundOverlays. A model with filtered GroundOverlays is saved in MarbleModel and used in TextureLayer, where the cache of GroundOverlays is handled. The actual rendering takes place in MergedLayerDecorator.
> 
> 
> Diffs
> -----
> 
>   src/lib/MarbleMap.cpp 102ed0d 
>   src/lib/MarbleModel.h 44a5f61 
>   src/lib/MarbleModel.cpp 3c44f9d 
>   src/lib/MergedLayerDecorator.h 2823cfc 
>   src/lib/MergedLayerDecorator.cpp 6363d8e 
>   src/lib/geodata/data/GeoDataGroundOverlay.h 2e144af 
>   src/lib/geodata/data/GeoDataGroundOverlay.cpp 0a87dc4 
>   src/lib/layers/GeometryLayer.cpp 20fd6a7 
>   src/lib/layers/TextureLayer.h 1dbd114 
>   src/lib/layers/TextureLayer.cpp 5b9e9c9 
> 
> Diff: http://git.reviewboard.kde.org/r/111499/diff/
> 
> 
> Testing
> -------
> 
> Tested with multiple overlapping overlays, different rotation angles.
> 
> 
> Thanks,
> 
> Adrian Draghici
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130719/058b96da/attachment.html>