<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111499/">http://git.reviewboard.kde.org/r/111499/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 14th, 2013, 10:31 a.m. UTC, <b>Dennis Nienhüser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111499/diff/1/?file=170557#file170557line172" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/layers/TextureLayer.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">171</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">const</span> <span class="n">GeoDataGroundOverlay</span> <span class="o">*</span><span class="n">overlay</span> <span class="o">=</span> <span class="k">static_cast</span><span class="o"><</span><span class="n">GeoDataGroundOverlay</span> <span class="o">*></span><span class="p">(</span><span class="n">qvariant_cast</span><span class="o"><</span><span class="n">GeoDataObject</span> <span class="o">*></span><span class="p">(</span> <span class="n">index</span><span class="p">.</span><span class="n">data</span><span class="p">(</span> <span class="n">MarblePlacemarkModel</span><span class="o">::</span><span class="n">ObjectPointerRole</span> <span class="p">)</span> <span class="p">)</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is it possible to use just one cast?</pre>
</blockquote>
<p>On July 15th, 2013, 11:30 a.m. UTC, <b>Adrian Draghici</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Not in this case, it doesn't work without it...</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adding Q_DECLARE_METATYPE( Marble::GeoDataGroundOverlay* ) towards the end of GeoDataGroundOverlay.h should fix that (cf. GeoDataObject.h)</pre>
<br />
<p>- Dennis</p>
<br />
<p>On July 15th, 2013, 11:30 a.m. UTC, Adrian Draghici wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble, Bernhard Beschow, Dennis Nienhüser, Torsten Rahn, and Thibaut Gridel.</div>
<div>By Adrian Draghici.</div>
<p style="color: grey;"><i>Updated July 15, 2013, 11:30 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds support for rendering GroundOverlays. A model with filtered GroundOverlays is saved in MarbleModel and used in TextureLayer, where the cache of GroundOverlays is handled. The actual rendering takes place in MergedLayerDecorator.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with multiple overlapping overlays, different rotation angles.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/MarbleMap.cpp <span style="color: grey">(102ed0d)</span></li>
<li>src/lib/MarbleModel.h <span style="color: grey">(44a5f61)</span></li>
<li>src/lib/MarbleModel.cpp <span style="color: grey">(3c44f9d)</span></li>
<li>src/lib/MergedLayerDecorator.h <span style="color: grey">(2823cfc)</span></li>
<li>src/lib/MergedLayerDecorator.cpp <span style="color: grey">(6363d8e)</span></li>
<li>src/lib/geodata/data/GeoDataGroundOverlay.h <span style="color: grey">(2e144af)</span></li>
<li>src/lib/geodata/data/GeoDataGroundOverlay.cpp <span style="color: grey">(0a87dc4)</span></li>
<li>src/lib/layers/GeometryLayer.cpp <span style="color: grey">(20fd6a7)</span></li>
<li>src/lib/layers/TextureLayer.h <span style="color: grey">(1dbd114)</span></li>
<li>src/lib/layers/TextureLayer.cpp <span style="color: grey">(5b9e9c9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111499/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>