[Marble-devel] Review Request 108616: QtMainWindow: unify Render Plugins Menus

Thibaut Gridel tgridel at free.fr
Tue Jan 29 19:52:11 UTC 2013

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 29, 2013, 7:52 p.m.)

Review request for Marble.


New attempt, taking into account tackat's remarks:
- Top level tools stay at beginning of view menu.
- Theme specific options stay below in the view menu.

QtMainWindow does not need anymore:
- to handle Crosshairs as a special plugin (it's now a toplevel entry)
- to handle Atmosphere plugin and options as a special case (atmosphere plugin handles its menu availability)


Builds 3 menu lists with all the render plugins:
- Info boxen
- Online Services
- Tools

More work needed to have atmosphere totally integrated.
An alternative can be to use more RenderPlugins::renderTypes and separate further real tools, {sun/atmosphere/stars}, info boxes, online services

Diffs (updated)

  src/QtMainWindow.h bfe9ba7 
  src/QtMainWindow.cpp 9224240 
  src/lib/AbstractFloatItem.h fefa85d 
  src/lib/AbstractFloatItem.cpp 658abab 
  src/lib/RenderPlugin.h 577da7a 
  src/plugins/render/atmosphere/AtmospherePlugin.h 320e800 
  src/plugins/render/atmosphere/AtmospherePlugin.cpp 765a9c2 
  src/plugins/render/crosshairs/CrosshairsPlugin.h ffaf8b9 
  src/plugins/render/crosshairs/CrosshairsPlugin.cpp 363a50d 
  src/plugins/render/stars/StarsPlugin.h aaef67c 
  src/plugins/render/stars/StarsPlugin.cpp 28d8e9e 

Diff: http://git.reviewboard.kde.org/r/108616/diff/


File Attachments

Render Plugins


Thibaut Gridel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130129/92a6c97b/attachment.html>

More information about the Marble-devel mailing list