[Marble-devel] Review Request 108616: QtMainWindow: unify Render Plugins Menus

Thibaut Gridel tgridel at free.fr
Sun Jan 27 17:36:17 UTC 2013

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 27, 2013, 5:36 p.m.)

Review request for Marble.


First, let me introduce that the menus at stake in the patch have one checkbox per plugin to toggle the visibility, nothing more fancy.
The patch tries to fix the current approach of hardcoding plugins, which doesn't make nice code.

I uploaded the result of that "Tools" menu and you are absolutely right that this is a mess.

The intent however is to provide a scalable solution for those forgotten plugins and decide if they should be
- Top level entries tools that users can hide/show (crosshairs, current position arrow, annotation)
- "hidden" plugins (and thus not user toggable and not present in menus ever)? (measure tool, elevation plugin specific cross)
- plugins to enable for user choice by theme settings (think different planets: atmosphere, stars, sun)

In the initial description i proposed: "An alternative can be to use more RenderPlugins::renderTypes and separate further ..."
Can we agree this is the way forward and provide enough rendertypes to feed the necessary menus?
On the functionnal side, can we discuss the different values for RenderTypes?


Builds 3 menu lists with all the render plugins:
- Info boxen
- Online Services
- Tools

More work needed to have atmosphere totally integrated.
An alternative can be to use more RenderPlugins::renderTypes and separate further real tools, {sun/atmosphere/stars}, info boxes, online services


  src/QtMainWindow.h bfe9ba7 
  src/QtMainWindow.cpp 9224240 

Diff: http://git.reviewboard.kde.org/r/108616/diff/


File Attachments (updated)

Render Plugins


Thibaut Gridel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130127/37f03332/attachment.html>

More information about the Marble-devel mailing list