<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108616/">http://git.reviewboard.kde.org/r/108616/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Thibaut Gridel.</div>
<p style="color: grey;"><i>Updated Jan. 29, 2013, 7:52 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">New attempt, taking into account tackat's remarks:
- Top level tools stay at beginning of view menu.
- Theme specific options stay below in the view menu.
QtMainWindow does not need anymore:
- to handle Crosshairs as a special plugin (it's now a toplevel entry)
- to handle Atmosphere plugin and options as a special case (atmosphere plugin handles its menu availability)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds 3 menu lists with all the render plugins:
- Info boxen
- Online Services
- Tools
More work needed to have atmosphere totally integrated.
An alternative can be to use more RenderPlugins::renderTypes and separate further real tools, {sun/atmosphere/stars}, info boxes, online services</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/QtMainWindow.h <span style="color: grey">(bfe9ba7)</span></li>
<li>src/QtMainWindow.cpp <span style="color: grey">(9224240)</span></li>
<li>src/lib/AbstractFloatItem.h <span style="color: grey">(fefa85d)</span></li>
<li>src/lib/AbstractFloatItem.cpp <span style="color: grey">(658abab)</span></li>
<li>src/lib/RenderPlugin.h <span style="color: grey">(577da7a)</span></li>
<li>src/plugins/render/atmosphere/AtmospherePlugin.h <span style="color: grey">(320e800)</span></li>
<li>src/plugins/render/atmosphere/AtmospherePlugin.cpp <span style="color: grey">(765a9c2)</span></li>
<li>src/plugins/render/crosshairs/CrosshairsPlugin.h <span style="color: grey">(ffaf8b9)</span></li>
<li>src/plugins/render/crosshairs/CrosshairsPlugin.cpp <span style="color: grey">(363a50d)</span></li>
<li>src/plugins/render/stars/StarsPlugin.h <span style="color: grey">(aaef67c)</span></li>
<li>src/plugins/render/stars/StarsPlugin.cpp <span style="color: grey">(28d8e9e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108616/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/27/renderplugins.jpg">Render Plugins</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>